Fix my own PR suggestions

fishjam-dev · Aug 31, 2023 · e6420ef · e6420ef
1 parent 4be7afb
commit e6420ef
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 20 deletions.
diff --git a/examples/readme.md b/examples/readme.md
@@ -12,4 +12,12 @@ List of examples:
   - receive media from other peers
   - almost no UI
 
-// todo add description
+- [useCameraAndMicrophone hook](https://github.com/jellyfish-dev/react-client-sdk/tree/main/examples/use-camera-and-microphone) - minimal
+  example of usage of `useCameraAndMicrophone` hook
+
+  - TypeScript with React Client
+  - connect to Jellyfish server
+  - join room
+  - set up audio and video devices separately
+  - decide whether to send them automatically
+  - almost no UI
diff --git a/examples/use-camera-and-microphone-example/src/App.tsx b/examples/use-camera-and-microphone-example/src/App.tsx
@@ -16,17 +16,6 @@ import { AUDIO_TRACK_CONSTRAINTS, VIDEO_TRACK_CONSTRAINTS } from "@jellyfish-dev
 import { Fragment } from "react";
 import { Badge } from "./Badge";
 
-// todo fix error
-//  webRTCEndpoint.js:991 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getSenders')
-//     at WebRTCEndpoint2.findSender (webRTCEndpoint.js:991:32
-// {
-//     streamWhenConnected: false,
-//     startStreamingWhenDeviceReady: true,
-//     startOnMount: false,
-//     storage: true,
-// }
-// Click connect -> start devices
-// Jeżeli zaczniesz streamować urządzenia bardzo szybko to wybucha.
 const tokenAtom = atomWithStorage("token", "");
 
 const videoAutoStreamingAtom = atomWithStorage<boolean | undefined>("videoAutoStreaming", undefined);
@@ -74,10 +63,10 @@ export const App = () => {
       autoStreaming: videoAutoStreaming,
       preview: videoPreview,
       defaultTrackMetadata: DEFAULT_VIDEO_TRACK_METADATA,
-      // defaultSimulcastConfig: {
-      //   enabled: true,
-      //   active_encodings: ["l", "m", "h"]
-      // }
+      defaultSimulcastConfig: {
+        enabled: true,
+        active_encodings: ["l", "m", "h"]
+      }
     },
     microphone: {
       trackConstraints: AUDIO_TRACK_CONSTRAINTS,

diff --git a/src/create.tsx b/src/create.tsx
@@ -284,10 +284,6 @@ const onConnect = <PeerMetadata, TrackMetadata>(
     action.dispatch({ type: "onDisconnected" });
   });
 
-  // important jeżeli użytkownik zapnie się na eventy z JellyfishClient
-  //  to one mogą się odpalić wcześniej niż te tutaj zasetupowane metody
-  //  tak się dzieje na przykład z eventem joined gdy chcę od razu zacząć
-  //  przesyłać tracki zaraz po dołączeniu
   client.on("joined", (peerId: string, peersInRoom: Endpoint[]) => {
     action.dispatch({ type: "onJoinSuccess", peersInRoom, peerId, peerMetadata });
   });