Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flat obj creation and filtering #1

Open
fischer-hub opened this issue Oct 4, 2022 · 0 comments
Open

Improve flat obj creation and filtering #1

fischer-hub opened this issue Oct 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@fischer-hub
Copy link
Owner

Instead of relying on the flat attributes to be separated by \n's maybe scan for keywords or units of measurement (euro-sign, square-meter-symbol) to identify the attributes from the flat's text. Right now if the first attribute or its newline char are missing, every following attribute will be assigned incorrectly.

Like this, we could also filter for attributes directly instead of filtering for words contained in the flat's text. This brings problems if one e.g. wants to filter for flats located in district spandau (hence filter config sting will be spandau,...) but now also flats in spandauer straße will be filtered out, which may not even be in the district spandau.

Now, this can be fixed by putting 'spandau ' instead of 'spandau' (trailing whitespace) into the filter string, however, this is kinda hacky and doesn't work if one wants to filter for room count, e.g.: '4-ZIMMER '. This would not filter flats with the title '4-ZIMMER-WOHNUNG'.

@fischer-hub fischer-hub added the enhancement New feature or request label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant