Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a line break check before merging several Linux configs #273

Open
PKUZHOU opened this issue Apr 20, 2023 · 0 comments
Open

Need a line break check before merging several Linux configs #273

PKUZHOU opened this issue Apr 20, 2023 · 0 comments

Comments

@PKUZHOU
Copy link

PKUZHOU commented Apr 20, 2023

Recently I was stucked with an odd problem: after modifying the linux kernel it cannot boot properly due to missing "/init" dir which should have been installed via initramfs.

After inspection, I found the root cause is that, I didn't write a line break in my modified linux config , say firechip/base-workloads/br-base/linux-config:
image

Therefore, after marshal merges this config with initramfs.kfrag, two configs are put into one line, resulting in a failure.

image

image

I think we would better have some lines of code to do a line break check before running the config merging. Otherwise some new users may also meet the same problems occationally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant