Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

full_test.sh broken #26

Closed
NathanTP opened this issue May 27, 2019 · 1 comment
Closed

full_test.sh broken #26

NathanTP opened this issue May 27, 2019 · 1 comment

Comments

@NathanTP
Copy link
Contributor

A few things are wrong with the full_test.sh script:

  • test/spike.json is failing because a previous commit removed part of it accidently
  • failures are not being reported correctly because we pipe test results to 'tee' but check the exit status (it's checking tee's exit status instead of marshal's)
  • the 'clean' command can remove the symlinks for bare-metal tests
This was referenced Jun 3, 2019
Merged
Merged
@NathanTP
Copy link
Contributor Author

Resolved by #29

@NathanTP NathanTP mentioned this issue Jun 25, 2019
Merged
@sagark sagark mentioned this issue Jun 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NathanTP