Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[flow] type sourceMaps in actions #7925

Closed
jasonLaster opened this issue Feb 10, 2019 · 10 comments · Fixed by #8077
Closed

[flow] type sourceMaps in actions #7925

jasonLaster opened this issue Feb 10, 2019 · 10 comments · Fixed by #8077

Comments

@jasonLaster
Copy link
Contributor

@Mrigank11 recently helped us add flow types for our source map workers PR. It would be really great if we could now use that type in our redux actions.

I started it here and saw 17 warnings which look like legitimate flow warnings

diff --git a/src/actions/types/index.js b/src/actions/types/index.js
index 1285d332e..4f2d73837 100644
--- a/src/actions/types/index.js
+++ b/src/actions/types/index.js
@@ -17,6 +17,7 @@ import type { PauseAction } from "./PauseAction";
 import type { ASTAction } from "./ASTAction";
 import { clientCommands } from "../../client/firefox";
 import type { Panel } from "../../client/firefox/types";
+import typeof SourceMaps from "../../../packages/devtools-source-map/src";

 /**
  * Flow types
@@ -34,7 +35,7 @@ export type ThunkArgs = {
   dispatch: (action: any) => Promise<any>,
   getState: () => State,
   client: typeof clientCommands,
-  sourceMaps: any,
+  sourceMaps: SourceMaps,
   panel: Panel
 };
@Garee
Copy link
Contributor

Garee commented Feb 10, 2019

/claim

@claim claim bot assigned Garee Feb 10, 2019
@claim
Copy link

claim bot commented Feb 10, 2019

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@jasonLaster
Copy link
Contributor Author

Thanks @Garee!

@Garee
Copy link
Contributor

Garee commented Feb 13, 2019

/unclaim

I haven't found the time to make progress on this, sorry. I don't want to hold it up.

@claim
Copy link

claim bot commented Feb 13, 2019

Done 👍

@zzdjk6
Copy link

zzdjk6 commented Feb 13, 2019

/claim

@claim
Copy link

claim bot commented Feb 13, 2019

Thanks for claiming the issue! 👋

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

@zzdjk6
Copy link

zzdjk6 commented Mar 3, 2019

/unclaim

@ryanjduffy
Copy link
Contributor

/claim because why not, right @jasonLaster? ;)

@claim claim bot added the in progress label Mar 5, 2019
@claim
Copy link

claim bot commented Mar 5, 2019

Thanks for claiming the issue! 👋

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

🦊 Debugger team!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants