Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Update to devtools-reps 0.13.0 #4051

Closed
nchevobbe opened this issue Sep 16, 2017 · 2 comments
Closed

Update to devtools-reps 0.13.0 #4051

nchevobbe opened this issue Sep 16, 2017 · 2 comments

Comments

@nchevobbe
Copy link
Member

This new version of Reps has some nice performances wins since it lazy loads properties, and thus shouldn't hang when expanding large arrays for example. It also fetches automatically properties, entries and symbols so the debugger will get everything for free (almost)

The code of the ObjectInspector was changed significantly in order to achieve that, so consumers need to change the props passed to it.

As an example, see how this was done in the console.

The main thing is that the ObjectInspector now expects a createObjectClient function, which will create an ObjectClient for a given grip, so you don't have to pass specific callbacks to fetch and get object properties, entries and symbols.
It also accept a releaseActor function that will release actors used to fetch properties (the root actors lifecycle still need to be handled by the debugger though).


I am not sure I'll have enough time to work on this issue for the debugger, given that I don't know the codebase. But I'll happily help and review if someone is willing to do it :)

@jasonLaster
Copy link
Contributor

we should really prioritize this so that we can collaborate more easily

@jasonLaster jasonLaster modified the milestones: Nov 28th, Backlog Nov 21, 2017
@wldcordeiro
Copy link
Contributor

We ended up doing an update to 0.19 so I think we can close this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants