Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[Toolbox] Hot Reloading breaks SingleModulePlugin #1361

Closed
jasonLaster opened this issue Nov 30, 2016 · 1 comment
Closed

[Toolbox] Hot Reloading breaks SingleModulePlugin #1361

jasonLaster opened this issue Nov 30, 2016 · 1 comment
Assignees

Comments

@jasonLaster
Copy link
Contributor

jasonLaster commented Nov 30, 2016

We recently introduced SingleModulePlugin to help with issues where two modules would require the same module, but get different closure scopes: e.g.

  • toolbox / main would get a different clientType
  • networkRequest did not get the config when it was set in source-map-worker

This broke hotReloading because SMP relies on a string comparison of the modules to determine similarity and HR injected a react dependency with a different module id.

We'll fix this soon by stripping HR injected lines from the comparison

CC @juliandescottes

@jasonLaster
Copy link
Contributor Author

Fixed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant