Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest a directory for the compose file in the documentation #7708

Closed
3 tasks done
WaleedMortaja opened this issue Jul 1, 2023 · 5 comments
Closed
3 tasks done

Suggest a directory for the compose file in the documentation #7708

WaleedMortaja opened this issue Jul 1, 2023 · 5 comments

Comments

@WaleedMortaja
Copy link

WaleedMortaja commented Jul 1, 2023

Support guidelines

Description

Please provide a suggested directory to save the docker compose file(s) into, because the name of the directory becomes part of the docker container name. The name might be used in scripts like the script that is recommend in the backup page.

Different docker container names makes confusion like here and here

Solution

Edit the docs. Provide an example path for the docker compose file(s) so that it is assumed to be the default and consistent path between different installations. I personally suggest: ~/docker/firefly-iii

What are alternatives?

Use the container_name key in the docker compose file (reference)

Additional context

No response

@JC5
Copy link
Member

JC5 commented Jul 1, 2023

Nah I don't think so. I think people are smart enough to think about this themselves.

@WaleedMortaja
Copy link
Author

I still think it would be a good idea to suggest a path, or use container_name. However, I respect your opinion too.

@JC5
Copy link
Member

JC5 commented Jul 2, 2023

Not a bad idea, I missed that one. Check out the Docker file, what do you think?

@WaleedMortaja
Copy link
Author

It works as expected. Container names should be consistent now.
Thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

Hi there! This is an automatic reply. Share and enjoy

This issue is now 🔒 closed. Please be aware that closed issues are not watched.

  • If the original bug is not actually fixed, please feel free to open a new issue. Please refer to this issue for clarity.
  • Follow-up questions must be posted in a new discussion
  • Further replies to this issue will get no response.

Thank you for your contributions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants