Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: displaydoc #4113

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Uses displaydoc to derive error messages from doc comments to reduce duplication.

Reason

See above.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 45.63% and no project coverage change.

Comparison is base (8460464) 82.27% compared to head (ebf7b3b) 82.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4113   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         225      225           
  Lines       28470    28470           
=======================================
  Hits        23423    23423           
  Misses       5047     5047           
Flag Coverage Δ
4.14-c7g.metal 77.70% <50.64%> (ø)
4.14-m5d.metal 79.57% <45.65%> (ø)
4.14-m6a.metal 78.69% <44.68%> (ø)
4.14-m6g.metal 77.70% <50.64%> (ø)
4.14-m6i.metal 79.57% <45.65%> (ø)
5.10-c7g.metal 80.61% <50.64%> (ø)
5.10-m5d.metal 82.25% <45.65%> (ø)
5.10-m6a.metal 81.46% <44.68%> (ø)
5.10-m6g.metal 80.61% <50.64%> (ø)
5.10-m6i.metal 82.24% <45.65%> (ø)
6.1-c7g.metal 80.61% <50.64%> (ø)
6.1-m5d.metal 82.25% <45.65%> (ø)
6.1-m6a.metal 81.46% <44.68%> (ø)
6.1-m6g.metal 80.61% <50.64%> (ø)
6.1-m6i.metal 82.24% <45.65%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/cpu-template-helper/src/fingerprint/compare.rs 74.50% <0.00%> (ø)
src/cpu-template-helper/src/fingerprint/dump.rs 92.98% <0.00%> (ø)
src/cpu-template-helper/src/main.rs 76.38% <0.00%> (ø)
src/cpu-template-helper/src/template/dump/mod.rs 80.00% <0.00%> (ø)
src/cpu-template-helper/src/template/strip/mod.rs 97.43% <0.00%> (ø)
src/cpu-template-helper/src/utils/mod.rs 98.03% <0.00%> (ø)
src/firecracker/src/api_server_adapter.rs 0.00% <0.00%> (ø)
src/firecracker/src/main.rs 0.21% <0.00%> (ø)
src/firecracker/src/seccomp.rs 77.77% <0.00%> (ø)
src/rebase-snap/src/main.rs 61.95% <0.00%> (ø)
... and 60 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/cpu-template-helper/src/template/verify/mod.rs Outdated Show resolved Hide resolved
src/jailer/Cargo.toml Outdated Show resolved Hide resolved
src/seccompiler/src/lib.rs Outdated Show resolved Hide resolved
src/vmm/src/cpu_config/x86_64/cpuid/intel/normalize.rs Outdated Show resolved Hide resolved
ShadowCurse
ShadowCurse previously approved these changes Sep 20, 2023
@JonathanWoollett-Light JonathanWoollett-Light added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 20, 2023
src/seccompiler/src/backend.rs Show resolved Hide resolved
src/mmds/src/token.rs Show resolved Hide resolved
src/vmm/src/persist.rs Show resolved Hide resolved
src/vmm/src/resources.rs Show resolved Hide resolved
src/vmm/src/resources.rs Show resolved Hide resolved
src/vmm/src/resources.rs Show resolved Hide resolved
src/vmm/src/rpc_interface.rs Outdated Show resolved Hide resolved
src/vmm/src/rpc_interface.rs Outdated Show resolved Hide resolved
src/vmm/src/vmm_config/balloon.rs Outdated Show resolved Hide resolved
src/vmm/src/vstate/vm.rs Outdated Show resolved Hide resolved
Uses `displaydoc` to derive error messages from doc comments to reduce
duplication.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
@JonathanWoollett-Light JonathanWoollett-Light merged commit f326f18 into firecracker-microvm:main Sep 21, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants