-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: displaydoc #4113
Merged
JonathanWoollett-Light
merged 2 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:displaydoc
Sep 21, 2023
Merged
fix: displaydoc #4113
JonathanWoollett-Light
merged 2 commits into
firecracker-microvm:main
from
JonathanWoollett-Light:displaydoc
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
added
the
Priority: Low
Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
label
Sep 19, 2023
JonathanWoollett-Light
force-pushed
the
displaydoc
branch
10 times, most recently
from
September 19, 2023 16:06
ed2a4f1
to
1978262
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4113 +/- ##
=======================================
Coverage 82.27% 82.27%
=======================================
Files 225 225
Lines 28470 28470
=======================================
Hits 23423 23423
Misses 5047 5047
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
JonathanWoollett-Light
force-pushed
the
displaydoc
branch
from
September 19, 2023 16:17
1978262
to
cd80609
Compare
JonathanWoollett-Light
force-pushed
the
displaydoc
branch
from
September 20, 2023 08:46
cd80609
to
a19a597
Compare
ShadowCurse
reviewed
Sep 20, 2023
JonathanWoollett-Light
force-pushed
the
displaydoc
branch
from
September 20, 2023 10:28
a19a597
to
403359e
Compare
ShadowCurse
previously approved these changes
Sep 20, 2023
JonathanWoollett-Light
added
the
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
label
Sep 20, 2023
9 tasks
wearyzen
reviewed
Sep 21, 2023
Uses `displaydoc` to derive error messages from doc comments to reduce duplication. Signed-off-by: Jonathan Woollett-Light <[email protected]>
JonathanWoollett-Light
force-pushed
the
displaydoc
branch
from
September 21, 2023 08:27
803f1d3
to
bc40632
Compare
wearyzen
approved these changes
Sep 21, 2023
ShadowCurse
approved these changes
Sep 21, 2023
JonathanWoollett-Light
merged commit Sep 21, 2023
f326f18
into
firecracker-microvm:main
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Low
Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Uses
displaydoc
to derive error messages from doc comments to reduce duplication.Reason
See above.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.