Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walk Failing on Demux Snapshotter after Garbage Collection #652

Open
ginglis13 opened this issue May 26, 2022 · 2 comments
Open

Walk Failing on Demux Snapshotter after Garbage Collection #652

ginglis13 opened this issue May 26, 2022 · 2 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@ginglis13
Copy link
Contributor

Walk fails on task exit after garbage collection when using the demux snapshotter with error:

time="2022-05-26T17:37:20Z" level=error msg="Function called without namespaced context" error="namespace is required: failed precondition" function=Walk

This shows up in demux snapshotter logs; not seeing a related error in firecracker-containerd logs but we should root cause this.

@austinvazquez
Copy link
Contributor

I feel like this may not be the entire solution. Reran integration tests with the above fix and am now seeing the following logs.

time="2022-06-01T18:04:26Z" level=error msg="Function called without namespaced context" error="namespace is required: failed precondition" function=Walk
time="2022-06-01T18:04:26Z" level=debug msg="no namespace found, proxying walk function to all cached snapshotters" function=Walk
time="2022-06-01T18:04:26Z" level=error msg="Function called without namespaced context" error="namespace is required: failed precondition" function=Remove
time="2022-06-01T18:04:26Z" level=error msg="Function called without namespaced context" error="namespace is required: failed precondition" function=Remove

Garbage collection is unable to provide namespace for Remove requests. Should we consider broadcasting these as well if no namespace is provided?

@Kern-- @ginglis13

@austinvazquez
Copy link
Contributor

@ginglis13, I have opened #678 which addresses garbage collection using in-VM snapshotter. Please have a look and provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants