Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAILED_PRECONDITION Error with RAG Implementation #343

Closed
JGSolutions opened this issue Jun 7, 2024 · 5 comments
Closed

FAILED_PRECONDITION Error with RAG Implementation #343

JGSolutions opened this issue Jun 7, 2024 · 5 comments
Assignees
Labels
bug Something isn't working js

Comments

@JGSolutions
Copy link

JGSolutions commented Jun 7, 2024

Describe the bug
Implementing a semantic search for board games using Firestore and the RAG implementation with the retriever based from this article
https://firebase.google.com/docs/genkit/plugins/firebase

I did generate vector embeddings for 60K for the Firestore documents and defined a Flow (as below).
When I increase the limit in the retrieve method I always get this error:
FAILED_PRECONDITION: Generation resulted in no candidates matching provided output schema.

If I submit the same prompt with a limit of 5 instead, it works as expected.

To Reproduce

export const boardGameSuggestionFlow = defineFlow(
    {
        name: "boardGameSuggestionFlow",
        inputSchema: z.string(),
        outputSchema: GamesFlowOutput,
    },
    async (query: string) => {
        const docs = await retrieve({
            retriever: retrieverRef,
            query,
            options: {
                limit: 30, ---> This value always getting an error. If set to 5 it works
            },
        });

        const promptDot = await prompt("boardGameSuggestion");
        const result = await promptDot.generate({
            input: {
                query,
            },
            context: docs, // i always get docs response no matter what prompt i request
        });

        const { games } = result.output() as { games: Games[] };

        return games;
    }
);

Expected behavior
Just get the results as expected with the same query

Runtime (please complete the following information):

  • OS: MacOS - latest version
  • genKit 0.5.2

** Node version

  • node version 20.10.0

Additional context
How does the generate() and LLMs work?
Also takes a very long time to get a response. Is there a way to increase performance?

@JGSolutions JGSolutions added bug Something isn't working js labels Jun 7, 2024
@JGSolutions
Copy link
Author

Another question about setting the contentField property in the retriever.

Can i combine text into one field. For example i have 3 fields: category, mechanics and description and created a new field called 'content' that combined these 3 fields into one paragraph. Which I created a vector embedding based on this field.

@JGSolutions
Copy link
Author

Another question: Do i need to manipulate the docs data to certain type of object of the LLM to understand better?

@cabljac
Copy link
Contributor

cabljac commented Jun 25, 2024

Hey, what did you increase the limit to, to get the error? There is a limit of 1000 in firestore but presumably this error happened with fewer than 1000? I see you used 30 in your code

@cabljac
Copy link
Contributor

cabljac commented Jun 25, 2024

Can you share your prompt, and your genkit config? In particular what model are you using?

It seems maybe the large context is confusing the model a bit, and it's unable to produce a response in the output format you requested.

@cabljac cabljac self-assigned this Jun 25, 2024
@cabljac
Copy link
Contributor

cabljac commented Aug 21, 2024

Closing this as stale for now, feel free to reopen if this is still an issue.

@cabljac cabljac closed this as completed Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working js
Projects
Status: Done
Development

No branches or pull requests

2 participants