Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [ml_vision] APK double size with 0.12.0 coming from 0.9.10 #5990

Closed
jaumard opened this issue Apr 30, 2021 · 3 comments
Closed

🐛 [ml_vision] APK double size with 0.12.0 coming from 0.9.10 #5990

jaumard opened this issue Apr 30, 2021 · 3 comments
Labels
Needs Attention This issue needs maintainer attention. resolution: duplicate This issue or pull request already exists type: bug Something isn't working

Comments

@jaumard
Copy link
Contributor

jaumard commented Apr 30, 2021

Hello,

My APK was doing 39MB, after upgrading ml_vision I'm getting 66MB!!!

By checking the APK I see those new items:

Capture d’écran 2021-04-30 à 19 09 45

When previously I had only this:

Capture d’écran 2021-04-30 à 19 10 15

Also gaining 9MB with "models":

Capture d’écran 2021-04-30 à 19 19 28

Is those coming from this package too??

That's a huge issue to me, having a quick fix or workaround would be appreciated.

I have checked the gradle file of the plugin and saw that:

  api "com.google.firebase:firebase-ml-vision"

        implementation 'com.google.android.gms:play-services-vision:20.1.1'
        implementation 'com.google.android.gms:play-services-vision-common:19.1.1'
        implementation 'com.google.android.gms:play-services-vision-face-contour-internal:16.0.3'
        implementation 'com.google.android.gms:play-services-vision-image-labeling-internal:16.0.5'
        implementation 'com.google.android.gms:play-services-vision-image-label:18.0.5'
        implementation 'com.google.firebase:firebase-ml-vision-face-model:20.0.2'
        implementation 'com.google.firebase:firebase-ml-model-interpreter:22.0.4'

Compare to previously:

api 'com.google.firebase:firebase-ml-vision:20.0.0'
        implementation 'com.google.firebase:firebase-common:16.1.0'
        implementation 'androidx.annotation:annotation:1.0.0'
        implementation 'androidx.exifinterface:exifinterface:1.0.0'
@jaumard jaumard added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Apr 30, 2021
@tokyokamera
Copy link

tokyokamera commented May 3, 2021

I have same problem.Please fix it!

@jaumard
Copy link
Contributor Author

jaumard commented May 3, 2021

I have deleted manually those lines and rebuild my APK:

implementation 'com.google.android.gms:play-services-vision-face-contour-internal:16.0.3'
        implementation 'com.google.android.gms:play-services-vision-image-labeling-internal:16.0.5'
        implementation 'com.google.android.gms:play-services-vision-image-label:18.0.5'
        implementation 'com.google.firebase:firebase-ml-vision-face-model:20.0.2'
        implementation 'com.google.firebase:firebase-ml-model-interpreter:22.0.4'

And my APK is back to 30MB

@markusaksli-nc markusaksli-nc added the triage Issue is currently being triaged. label May 3, 2021
@markusaksli-nc
Copy link
Contributor

Hi @jaumard
I see there's an open issue addressing the case you described #4767.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you

@markusaksli-nc markusaksli-nc added resolution: duplicate This issue or pull request already exists and removed triage Issue is currently being triaged. labels May 3, 2021
@firebase firebase locked and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Attention This issue needs maintainer attention. resolution: duplicate This issue or pull request already exists type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants