Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [firebase_storage 5.0.0-dev.4] Update SDK to 26 #4013

Closed
dvird opened this issue Nov 2, 2020 · 4 comments
Closed

🐛 [firebase_storage 5.0.0-dev.4] Update SDK to 26 #4013

dvird opened this issue Nov 2, 2020 · 4 comments
Labels
plugin: storage type: bug Something isn't working

Comments

@dvird
Copy link

dvird commented Nov 2, 2020

In order to present percent progress, TaskState.running should send events after every few bytes.
Today its sending only 2 3 4 events, which is not enough for presenting well progress on our screen.

old SDK has StorageTaskEventType.progress which worked great, but since the refactor youve made its not working anymore
@dvird dvird added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Nov 2, 2020
@Ehesp
Copy link
Member

Ehesp commented Nov 2, 2020

This is the native SDK, we just relay the events on as they come through so it's nothing we've changed. The SDK versions have updated though.

@TahaTesser
Copy link

Hi @dvird
As mentioned above this is from native SDK, with no changes from the plugin itself
Thank you

@TahaTesser TahaTesser added blocked: customer-response Waiting for customer response, e.g. more information was requested. and removed Needs Attention This issue needs maintainer attention. labels Nov 3, 2020
@dvird
Copy link
Author

dvird commented Nov 4, 2020

@TahaTesser @Ehesp firebase storage is now 26, but flutter use 25. i read somewhere they fixed it already

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Nov 4, 2020
@TahaTesser TahaTesser added plugin: storage and removed Needs Attention This issue needs maintainer attention. labels Nov 5, 2020
@TahaTesser TahaTesser changed the title 🐛 [firebase_storage 5.0.0-dev.4] TaskState.running has only 3 4 events 🐛 [firebase_storage 5.0.0-dev.4] Update SDK to 26 Nov 5, 2020
@mikehardy mikehardy mentioned this issue Nov 27, 2020
Merged
10 tasks
@russellwheatley
Copy link
Member

As mentioned, this isn't something we have control over. More over, we're now using 26.2.0 android BOM version which ought to fix the android sdk issue.

@firebase firebase locked and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
plugin: storage type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Ehesp @russellwheatley @google-oss-bot @dvird @TahaTesser and others