Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚[ Firebase_messaging] gettings started docs have buggy code #3952

Closed
Tejaswgupta opened this issue Oct 26, 2020 · 2 comments · Fixed by #4012
Closed

📚[ Firebase_messaging] gettings started docs have buggy code #3952

Tejaswgupta opened this issue Oct 26, 2020 · 2 comments · Fixed by #4012
Labels
good first issue Good for newcomers type: documentation Improvements or additions to documentation

Comments

@Tejaswgupta
Copy link

The getting started of firebase_messaging plugin for the android section asks to create an Application.java file and put
GeneratedPluginRegistrant.registerWith(registry);

Where it throws and error and as discussed in an issue for the same , it should have been
FirebaseMessagingPlugin.registerWith(registry.registrarFor("io.flutter.plugins.firebasemessaging.FirebaseMessagingPlugin"));

The docs have not been update yet and can cause issue to someone who is getting started with the plugin

@Tejaswgupta Tejaswgupta added good first issue Good for newcomers type: documentation Improvements or additions to documentation labels Oct 26, 2020
@Tejaswgupta Tejaswgupta changed the title [📚] Firebase_messaging gettings started docs have buggy code 📚[ Firebase_messaging] gettings started docs have buggy code Oct 27, 2020
@dackers86
Copy link
Member

dackers86 commented Oct 28, 2020

PR linked at #3963

@dackers86
Copy link
Member

This is due to be refactored as part of the messaging rework. Please continue to use the code above or the example PR for now

@firebase firebase locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants