From e9e52ebc1e50c746da0fb9beac6858bc48c92311 Mon Sep 17 00:00:00 2001 From: Manny Jimenez Date: Sun, 8 Jan 2023 13:19:19 -0500 Subject: [PATCH 1/4] [WIP] Adding release links to firebase cli --- src/appdistribution/client.ts | 3 +++ src/commands/appdistribution-distribute.ts | 3 +++ src/test/appdistro/client.spec.ts | 4 ++++ 3 files changed, 10 insertions(+) diff --git a/src/appdistribution/client.ts b/src/appdistribution/client.ts index 432a379fb63..b85a5719c1e 100644 --- a/src/appdistribution/client.ts +++ b/src/appdistribution/client.ts @@ -46,6 +46,9 @@ export interface Release { displayVersion: string; buildVersion: string; createTime: Date; + firebaseConsoleUri: string; + testingUri: string; + binaryDownloadUri: string; } export interface ReleaseNotes { diff --git a/src/commands/appdistribution-distribute.ts b/src/commands/appdistribution-distribute.ts index 17721663dc3..5abf4baa13e 100644 --- a/src/commands/appdistribution-distribute.ts +++ b/src/commands/appdistribution-distribute.ts @@ -129,6 +129,9 @@ export const command = new Command("appdistribution:distribute { ).to.be.eventually.eq(fakeOperation); expect(nock.isDone()).to.be.true; }); + + it("should return release if upload succeeds", async() => { + nock(appDistributionOrigin).post() + } }); describe("updateReleaseNotes", () => { From 1fb5792f00faa5fce0969a0f01274e6e7aa6a981 Mon Sep 17 00:00:00 2001 From: Emmanuel Jimenez <32231345+mannyjimenez0810@users.noreply.github.com> Date: Sun, 8 Jan 2023 14:17:22 -0500 Subject: [PATCH 2/4] Update client.spec.ts --- src/test/appdistro/client.spec.ts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/test/appdistro/client.spec.ts b/src/test/appdistro/client.spec.ts index 68e249c4db0..1390257cf46 100644 --- a/src/test/appdistro/client.spec.ts +++ b/src/test/appdistro/client.spec.ts @@ -102,10 +102,6 @@ describe("distribution", () => { ).to.be.eventually.eq(fakeOperation); expect(nock.isDone()).to.be.true; }); - - it("should return release if upload succeeds", async() => { - nock(appDistributionOrigin).post() - } }); describe("updateReleaseNotes", () => { From 8359df94335456c2f8c7aa0a116f3fb6b7306a7f Mon Sep 17 00:00:00 2001 From: Emmanuel Jimenez <32231345+mannyjimenez0810@users.noreply.github.com> Date: Sun, 8 Jan 2023 14:48:17 -0500 Subject: [PATCH 3/4] Update appdistribution-distribute.ts --- src/commands/appdistribution-distribute.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/commands/appdistribution-distribute.ts b/src/commands/appdistribution-distribute.ts index 5abf4baa13e..91f01897377 100644 --- a/src/commands/appdistribution-distribute.ts +++ b/src/commands/appdistribution-distribute.ts @@ -131,7 +131,9 @@ export const command = new Command("appdistribution:distribute Date: Wed, 18 Jan 2023 12:00:18 -0500 Subject: [PATCH 4/4] Update appdistribution-distribute.ts --- src/commands/appdistribution-distribute.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/appdistribution-distribute.ts b/src/commands/appdistribution-distribute.ts index 91f01897377..572b8b6a216 100644 --- a/src/commands/appdistribution-distribute.ts +++ b/src/commands/appdistribution-distribute.ts @@ -130,7 +130,7 @@ export const command = new Command("appdistribution:distribute