Cache dependencies and archive builds in all workflows #8631
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (e3e2078) and merge commit (848646f).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (e3e2078) and merge commit (848646f).Test Logs |
dlarocque
force-pushed
the
dl/optimize-ci
branch
from
a9f9c96 to
a50ccc7
Compare
| node-version-file: '.nvmrc' | ||
| cache: yarn | ||
| cache-dependency-path: yarn.lock | ||
| - name: Restore cached node_modules |
There was a problem hiding this comment.
Do you have any metrics as to how much faster the act of caching is?
There was a problem hiding this comment.
So far what I've gathered is that without caching yarn install takes ~60s in CI, and the resulting node_modules is ~935MB. Restoring a cached node_modules (after a cache hit) takes only ~7s, and then the subsequent yarn install takes 5s.
I'll include more details in a section about speed changes in my PR description in a bit
.github/workflows/test-all.yml
Outdated
| path: "**/node_modules" | ||
| key: node_modules-${{ runner.arch }}-${{ runner.os }}-${{ hashFiles('yarn.lock') }} | ||
| - run: yarn install --frozen-lockfile | ||
| - name: install Chrome stable |
There was a problem hiding this comment.
The previous workflow started with the chrome installation as it seems to affect some tools installation. We're sure that it's safe to push it down this far?
There was a problem hiding this comment.
This is an oversight by me- I shouldn't have moved it down. It looks like it's passing though? https://github.com/firebase/firebase-js-sdk/actions/runs/11706621527/job/32604805660
Do you think I should move it back anyway? I'm not familiar with how this works
There was a problem hiding this comment.
I don't remember what it affected but I think it might be the chromedriver yarn install in the auth package. There might possibly be a hiccup on that install if it can't find some Chrome file. Or maybe not, maybe it doesn't matter if Chrome is there until the karma test begins to run. May be a comment somewhere in the old PRs messing with the Chrome installation in this workflow and chromedriver versions.
There was a problem hiding this comment.
I think it's worth moving it back to the top so that it stands out more.
.github/workflows/release-tweet.yml
Outdated
There was a problem hiding this comment.
I forgot we still had this workflow, by the way, I think we can get rid of it.
draft