Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade workflows Node version from 20.x to 22.10.0 #8601

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Oct 25, 2024

Node 22 enters LTS on October 29th, 2024, so we should upgrade CI to run on Node 22.

Would there be any benefits to using 22.x instead of 22.10.0? I specified an exact version in case it helps with reproducibility.

Node 22 enters LTS on October 29th, 2024, so we should upgrade CI to run
on Node 22.

Would there be any benefits to using `22.x` instead of `22.10.0`? I
specified an exact version in case it helps with reproducability.
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 943846a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

@dlarocque dlarocque marked this pull request as ready for review October 25, 2024 14:59
@dlarocque dlarocque requested a review from a team as a code owner October 25, 2024 14:59
@dlarocque dlarocque merged commit d4cb3f8 into main Oct 28, 2024
39 checks passed
@dlarocque dlarocque deleted the dl/ci-node-22 branch October 28, 2024 18:32
ashish-kothari added a commit that referenced this pull request Nov 24, 2024
Squashed commit of the following:

commit ffbf5a6
Author: Google Open Source Bot <[email protected]>
Date:   Thu Nov 14 07:04:30 2024 -0800

    Version Packages (#8635)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

commit 2c27206
Merge: a75082f e3e2078
Author: Google Open Source Bot <[email protected]>
Date:   Tue Nov 12 07:48:12 2024 -0800

    Merge main into release

commit e3e2078
Author: Daniel La Rocque <[email protected]>
Date:   Wed Nov 6 09:57:57 2024 -0500

    Consolidate CI test output into a single string (#8489)

    * Consolidate CI test output into a single string

    Having CI test process stdout and stderr in a single string makes it
    easier to read when looking through failures, since you can see the test
    output alongside the error messages.

    Without this, any stderr output written during a test will be captured
    seperately from the test output, so when we then log it after a test
    failure, we can't tell which test logged which errors.

    * Prefix stdout and stderr output

commit 274e9a5
Author: Daniel La Rocque <[email protected]>
Date:   Tue Nov 5 17:25:54 2024 -0500

    Remove unused `convertPropertiesForEnclosingClass" (#8618)

commit caf3090
Author: Daniel La Rocque <[email protected]>
Date:   Wed Oct 30 15:12:32 2024 -0400

    Upgrade ts-node to 10.19.2 (#8531)

commit 0f5714b
Author: Mark Duckworth <[email protected]>
Date:   Wed Oct 30 10:05:19 2024 -0600

    Fix for 8474 - Prevent a possible condition of slow snapshots, caused by a rapid series of document update(s) followed by a delete. (#8595)

commit d4cb3f8
Author: Daniel La Rocque <[email protected]>
Date:   Mon Oct 28 14:32:13 2024 -0400

    Upgrade workflows Node version from `20.x` to `22.10.0` (#8601)

    Node 22 enters LTS on October 29th, 2024, so we should upgrade CI to run
    on Node 22.

commit b807119
Author: Daniel La Rocque <[email protected]>
Date:   Fri Oct 25 15:16:08 2024 -0400

    Remove modifiers from compat overloads (#8604)

    * Remove modifiers from compat overloads

    * format

    * Add changeset

commit 612335d
Author: Daniel La Rocque <[email protected]>
Date:   Fri Oct 25 14:31:32 2024 -0400

    Upgrade webpack dependencies in e2e tests (#8605)
@firebase firebase locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants