firebase/database-compat - Breaks the node version requirement

[sanhardik]

Operating System

Ubuntu

Environment (if applicable)

NodeJs 16.20.2

Firebase SDK Version

12.1.1

Firebase SDK Product(s)

Database

Project Tooling

NodeJS backend using firebase-admin v12.1.1

Detailed Problem Description

We are running our code on Node 16 due to some other dependency issues.
We use firebase-admin v12.1.1
The firebase-admin has got a dependency on @firebase/database-compat
"@firebase/database-compat": "^1.0.2",

The recent version of @firebase/database-compat introduced the minimum node version as 18, thus breaking all our build.
error @firebase/[email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

I would have thought that updates like this would need a major version change as it breaks existing code bases.

Fixing an older version of firebase-admin's package to fix it to a version might not be an option.

My suggestion is to revert the change on @firebase/[email protected] to allow older node version and build a new major release

Steps and code to reproduce issue

Install firebase-admin on Node16

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[dlarocque]

Hey @sanhardik, thanks for reporting this issue. We recently did a major version release (v11) of the Firebase JS SDK where we dropped support for Node <18.

Node 16 has reached EOL (https://nodejs.org/en/blog/announcements/nodejs16-eol) and it's highly recommended to upgrade. Would it be possible to upgrade to Node 18 to resolve this?

[sanhardik]

Hello, I do understand the reason to upgrade node version. But this is a legacy codebase, with a whole bunch of packages that won't work beyond Node 16. So upgrading to Node 18 is a major project, which is not on our roadmap.

…

On Wed, 23 Oct 2024, 1:32 am Daniel La Rocque, ***@***.***> wrote: Hey @sanhardik <https://github.com/sanhardik>, thanks for reporting this issue. We recently did a major version release (v11) of the Firebase JS SDK where we dropped support for Node <18. Node 16 has reached EOL ( https://nodejs.org/en/blog/announcements/nodejs16-eol) and it's highly recommended to upgrade. Would it be possible to upgrade to Node 18 to resolve this? — Reply to this email directly, view it on GitHub <#8583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACC6SXHBKIEN43MR2IVTQRTZ4ZOXZAVCNFSM6AAAAABQLNPKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGQ2TMNRZGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dlarocque]

@sanhardik No worries if you can't upgrade to Node 18.

To resolve this, we will release a new version of @firebase/database-compat that reverts the Node >=18 requirement, so that the next time you install your dependencies you will have a version that does not require Node 18. I will share an update here when that process is finished.

[sanhardik]

That's great. Would you also remove the caret in package.json for firebase-admin or database-compat with node enforcement will be a major release ? Just trying to ensure that future release versions don't have the same problem Thankss

…

On Wed, 23 Oct 2024, 4:23 am Daniel La Rocque, ***@***.***> wrote: @sanhardik <https://github.com/sanhardik> No worries if you can't upgrade to Node 18. To resolve this, we will release a new version of @firebase/database-compat that reverts the Node >=18 requirement, so that the next time you install your dependencies you will have a version that does not require Node 18. I will share an update here when that process is finished. — Reply to this email directly, view it on GitHub <#8583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACC6SXBECVIP6LOGFJNLAUTZ42CYTAVCNFSM6AAAAABQLNPKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZHA2DOMBVGY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dlarocque]

@sanhardik Yes, we will make a separate major release for the version of database-compat that requires Node >16, so this issue should not occur again in the future.

[sanhardik]

Awesome, thank you so much!

…

On Wed, 23 Oct 2024, 6:06 am Daniel La Rocque, ***@***.***> wrote: @sanhardik <https://github.com/sanhardik> Yes, we will make a separate major release for the version of database-compat that requires Node >16, so this issue should not occur again in the future. — Reply to this email directly, view it on GitHub <#8583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACC6SXENIG3IFWSWJGFO6D3Z42O2HAVCNFSM6AAAAABQLNPKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQGAZTONBXGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[dlarocque]

@sanhardik This should be fixed now. Can you try re-installing and confirm this?

[sanhardik]

Hello, The issue with database-compat got resolved but now I am seeing issues with @***@***.*** @***@***.*** @***@***.*** @***@***.*** It seems like anything got published in the last few days, had this requirement turned on in the minor versions. Thanks Hardik

…

On Wed, 23 Oct 2024 at 06:24, Daniel La Rocque ***@***.***> wrote: @sanhardik <https://github.com/sanhardik> This should be fixed now. Can you try re-installing and confirm this? — Reply to this email directly, view it on GitHub <#8583 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACC6SXA2H77BNLWYJYVRGC3Z42Q7VAVCNFSM6AAAAABQLNPKMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQGA3TEOBTGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thanks, Hardik Sanghavi

[dlarocque]

Hello, The issue with database-compat got resolved but now I am seeing issues with @@.*** @@.*** @@.*** @@.***

I am not sure what that error message is. Did it get formatted correctly?

[sanhardik]

Sorry, I had replied back with email causing the issues

The error is
The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

For these packages

@firebase/[email protected]
@firebase/[email protected]
@firebase/[email protected]
@firebase/[email protected]

[dlarocque]

@sanhardik Thanks for sharing the error again- really sorry for the trouble.

To fix this, the Firebase Admin Node SDK has released a new version that pins the versions of @firebase/ dependencies to ones that don't require Node 18.
Could you try upgrading to "firebase-admin": "12.7.0" to get these pinned dependencies?

[sanhardik]

Hello,
Sorry for the delay.
I did update the firebase-admin to 12.7.0.

I am now seeing an error with farmhash-modern
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

[dlarocque]

Hello, Sorry for the delay. I did update the firebase-admin to 12.7.0.

I am now seeing an error with farmhash-modern error [email protected]: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"

Hi @sanhardik, thanks for the update. This seems to be a different issue- farmhash-modern is a dependency of the Admin SDK. Could you please report this in a new issue in https://github.com/firebase/firebase-admin-node?

While this is still unresolved, you may be able to use selective version resolutions with your previous version of the Admin SDK (12.1.1), and add the following to your package.json:

"resolutions": {
    "@firebase/database-compat": "1.0.8", 
    "@firebase/database-types": "1.0.5" 
  }

[sanhardik]

I have reported the issue at firebase/firebase-admin-node#2753