From 60dce81bd4a60afb796a5383cbc2e8bfacd7b37b Mon Sep 17 00:00:00 2001 From: Denver Coneybeare Date: Wed, 2 Nov 2022 12:52:29 -0400 Subject: [PATCH] Revert spec test changes from https://github.com/firebase/firebase-js-sdk/pull/6624 since the fix for its issue isn't fixed yet (it will be fixed by https://github.com/firebase/firebase-ios-sdk/pull/10437) --- .../SpecTests/json/listen_spec_test.json | 54 +------------------ .../SpecTests/json/recovery_spec_test.json | 14 ----- 2 files changed, 2 insertions(+), 66 deletions(-) diff --git a/Firestore/Example/Tests/SpecTests/json/listen_spec_test.json b/Firestore/Example/Tests/SpecTests/json/listen_spec_test.json index 5755019b048..193d40005b5 100644 --- a/Firestore/Example/Tests/SpecTests/json/listen_spec_test.json +++ b/Firestore/Example/Tests/SpecTests/json/listen_spec_test.json @@ -2261,6 +2261,7 @@ "describeName": "Listens:", "itName": "Empty initial snapshot is raised from cache", "tags": [ + "no-ios" ], "config": { "numClients": 1, @@ -2688,6 +2689,7 @@ "describeName": "Listens:", "itName": "Empty-due-to-delete initial snapshot is raised from cache", "tags": [ + "no-ios" ], "config": { "numClients": 1, @@ -3856,25 +3858,6 @@ }, "targetId": 2 }, - "expectedSnapshotEvents": [ - { - "errorCode": 0, - "fromCache": true, - "hasPendingWrites": false, - "query": { - "filters": [ - [ - "visible", - "==", - true - ] - ], - "orderBys": [ - ], - "path": "collection" - } - } - ], "expectedState": { "activeTargets": { "2": { @@ -3996,20 +3979,6 @@ }, "targetId": 4 }, - "expectedSnapshotEvents": [ - { - "errorCode": 0, - "fromCache": true, - "hasPendingWrites": false, - "query": { - "filters": [ - ], - "orderBys": [ - ], - "path": "collection" - } - } - ], "expectedState": { "activeTargets": { "4": { @@ -4386,25 +4355,6 @@ }, "targetId": 2 }, - "expectedSnapshotEvents": [ - { - "errorCode": 0, - "fromCache": true, - "hasPendingWrites": false, - "query": { - "filters": [ - [ - "visible", - "==", - true - ] - ], - "orderBys": [ - ], - "path": "collection" - } - } - ], "expectedState": { "activeTargets": { "2": { diff --git a/Firestore/Example/Tests/SpecTests/json/recovery_spec_test.json b/Firestore/Example/Tests/SpecTests/json/recovery_spec_test.json index 9ae9f2349ff..c42d58c9d41 100644 --- a/Firestore/Example/Tests/SpecTests/json/recovery_spec_test.json +++ b/Firestore/Example/Tests/SpecTests/json/recovery_spec_test.json @@ -1012,20 +1012,6 @@ }, "targetId": 2 }, - "expectedSnapshotEvents": [ - { - "errorCode": 0, - "fromCache": true, - "hasPendingWrites": false, - "query": { - "filters": [ - ], - "orderBys": [ - ], - "path": "collection" - } - } - ], "expectedState": { "activeTargets": { "2": {