Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why retryConfig is only available for scheduled functions? #699

Closed
sk- opened this issue Jun 9, 2020 · 5 comments
Closed

Why retryConfig is only available for scheduled functions? #699

sk- opened this issue Jun 9, 2020 · 5 comments

Comments

@sk-
Copy link
Contributor

sk- commented Jun 9, 2020

Currently only scheduled functions have a retry config, however all background functions support retries, see https://firebase.google.com/docs/functions/retries.

Given that the underlying technology for all the background functions is pubsub, it should be straightforward to add the retry config to the other function types.

For us this would simplify our development, as a bunch of our firestore triggers are randomly failing either with a RST error, or with no error at all. And having a consistent way of specifying the retries would be quite nice.

@google-oss-bot
Copy link
Collaborator

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@sk-
Copy link
Contributor Author

sk- commented Jul 30, 2020

This feature is now even more pressing as Cloud Console changed the UI to edit a function and now we are unable to edit them. See https://issuetracker.google.com/u/0/issues/162440541.

gcloud is not an option either because it requires to pass the source code of the function.

Please advise if there are any workarounds.

@sk-
Copy link
Contributor Author

sk- commented Aug 12, 2020

@mbleigh any chance this could be prioritized or maybe you could bump the internal issue related to https://issuetracker.google.com/u/0/issues/162440541.

@stari4ek
Copy link

I'd like to confirm the problem mentioned by @sk- .

There is no way to enable retries for firebase functions using GCP UI now.
When I enable "Retry on failure" for function with "Cloud Firestore" trigger - it requires to re-deploy function using web UI.
Using already deployed source code ("Inline Editor" selected) gives build error (most probably since it expects google cloud function and does not have any magic applied by firebase cli): Build failed: function.js does not exist; Error ID: 7485c5b6

So it means there is no way to enable retries at all.

@sk-
Copy link
Contributor Author

sk- commented Aug 29, 2020

This should be fixed by #760 and available in the next release of firebase-tools. See firebase/firebase-tools#1734 (comment)

@sk- sk- closed this as completed Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants