ES6 Suport Broken

[bassrock]

Describe your environment

• Operating System version: mac osx
• Firebase SDK version: 12.1.0
• Firebase Product: gcm/push
• Node.js version: 20.11
• PNPM version: 8

Steps to reproduce:

When using firebase sdk in an ES6 environment where the tsconfig looks like:

{
  "$schema": "https://json.schemastore.org/tsconfig",
  "compilerOptions": {
    "experimentalDecorators": true,
    "emitDecoratorMetadata": true,
    "target": "ESNext",
    "module": "NodeNext",
    "moduleResolution": "NodeNext",
    "removeComments": true,
    "esModuleInterop": true,
    "noEmitOnError": false,
    "sourceMap": true,
    "inlineSources": true,
    "sourceRoot": "/",
    "declaration": true,
    "noEmitHelpers": true,
    "importHelpers": true
  }
}

and the package.json is set to type: "module" you get the following error with the long module:

../../node_modules/.pnpm/[email protected]/node_modules/long/umd/index.d.ts:1:18 - error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("../index.js")' call instead.

Relevant Code:

I believe the issue may be this line

firebase-admin-node/src/remote-config/condition-evaluator-internal.ts

Line 29 in 7463d1c

import long = require('long');

but I am not totally sure.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[elliottAtTreatment]

My entire team and i also ran into this issue. Been present for at least several weeks if not much longer. It occurs in all our applications using typescript, node.js, and a firebase-admin import.

We now have been resorting to adding:
"skipLibCheck": true

tsconfig:
{
"compilerOptions": {
"rootDir": "src",
"outDir": "dist",
"target": "es2022",
"module": "NodeNext",
"sourceMap": true,
"allowJs": false,
"alwaysStrict": true,
"resolveJsonModule": true,
"noImplicitAny": true,
"strictNullChecks": true,
"esModuleInterop": true,
"skipLibCheck": true
}
}

[lahirumaramba]

Hey folks, thanks for reporting this issue! I am having trouble reproducing this... my code seem to build on NodeJS 20.11 with ES6. Are you able to provide us a minimal repro? Thanks!

[lahirumaramba]

This should be fixed in #2614
Please open a new issue if you still have problems. Thanks!

[larssn]

@lahirumaramba When will this make it into a release? Curious if this is what I'm experiencing here: #2639

[jsmenzies]

@larssn release was a few days ago,

I'm getting the same issue with the new version though as the dependency is still imported it's just marked as optional.

Long is imported already by another one of my deps '@apollo/server@"4.10.5' so I'm not sure if that make a difference but it seems the error is coming from:

node_modules/@grpc/proto-loader/node_modules/long/umd/index.d.ts

and not

node_modules/long

Is there anyway we can remove the optional dependency or I can exclude it?