-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Support Cloud Storage #71
Comments
Seems like a good addition. Except I wouldn't call the class
|
Name is StorageClientHelper, I understand. StorageClient support custom encryption key like this.
This class should support this function like this.
What do you think? |
Hi @takuya1981. Thanks again for thinking about this. I'm not convinced that we should expose custom encryption keys at this stage. We haven't exposed it in other languages. Therefore let's start with just
We can support encryption keys in the future if we want to, but that should be supported across all languages if we do that. |
Correction. We can just expose the StorageClient as a static:
|
I understand that encryption key is not needed at the moment and signature of method. And I opened draft pull request, draft means that encryption key is still supported, I'll delete it. |
I opened pull request. Please review it. |
firebase-admin-dotnet does not support Cloud Storage yet.
I'd like to contribute for it.
The simple specifications are as follows:
I would like to open a pull request about the above if there are no problems.
The text was updated successfully, but these errors were encountered: