Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for HTTP/2 #356

Open
TommyN opened this issue Aug 1, 2023 · 4 comments
Open

Feature Request: Add support for HTTP/2 #356

TommyN opened this issue Aug 1, 2023 · 4 comments
Assignees
Labels
api: messaging type: enhancement New feature or request type: feature request A new feature API is requested

Comments

@TommyN
Copy link

TommyN commented Aug 1, 2023

Modifying the FirebaseMessaingClient.SendAsync and adding new Version(2, 0) should allow HTTP/2 to be used.

  ...
  var request = new HttpRequestMessage()
  {
    Version = new Version(2, 0),
    Method = HttpMethod.Post,
    RequestUri = new Uri(this.sendUrl),
    Content = NewtonsoftJsonSerializer.Instance.CreateJsonHttpContent(body),
  };

Users of this library would probably also want to configure the EnableMultipleHttp2Connections property, but as far as I can gather this requires changes in the Google.Apis.Core and requires >= .NET 5

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@ewfian
Copy link

ewfian commented Aug 3, 2023

Related: #349 (comment)

@JensSchadron
Copy link

@lahirumaramba Any news on this?
Because of the deprecation of the FCM batch API endpoint (in 15 days from now) and the HTTP V1 API relying mostly on HTTP/2 multiplexing to achieve greater throughput, this seems like a pretty important thing to look into.

@nbevans
Copy link

nbevans commented Oct 1, 2024

This could be solved if we could supply a custom HttpMessageHandler to the underlying HttpClient, it would solve the issue. Is that possible? Can it be made possible?

Because then you could reference the System.Net.Http.WinHttpHandler nuget which provides HTTP2 on older .NET Framework runtimes, and also provide a suitable workaround for many other scenarios.

@lahirumaramba lahirumaramba self-assigned this Oct 4, 2024
@lahirumaramba lahirumaramba added api: messaging type: feature request A new feature API is requested type: enhancement New feature or request and removed needs-triage labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: messaging type: enhancement New feature or request type: feature request A new feature API is requested
Projects
None yet
Development

No branches or pull requests

6 participants