Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link, ClickAction Https Validation, before request. #346

Open
Davidos533 opened this issue Apr 25, 2023 · 1 comment
Open

Link, ClickAction Https Validation, before request. #346

Davidos533 opened this issue Apr 25, 2023 · 1 comment

Comments

@Davidos533
Copy link

Davidos533 commented Apr 25, 2023

[REQUIRED] Step 2: Describe your environment

  • Operating System version: x64
  • Firebase SDK version: 2.3.0
  • Firebase Product: Cloud Messaging
  • .NET version: .NET 6.0
  • OS: Win10

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

I trying to send a push messaage with:
-Webpush data (FcmOptions.Link)
-Android data (Notification.ClickAction)

Link and ClickAction same, this is http links, not https, because this is my local development enviroment.
When i developing i want to send messages with http links that pointing on my local circuit wtihout https.

Before message sends, it's validating, and validation checks link only in webpush, Android click action does not checks, and if link not https throws exception with mesage:

System.ArgumentException: 'The link options should be a valid https url.'

image

I want to have a opportunity to disable this validation, but in best case scenario remove this validation from code, beacause i dowloaded source code, and used it instead of package, after removing https checks, and FCM succeffully processed this message, when i got it and clicked on message, my browser successfully opened on http - link.

this place in source code:

using System;
using Newtonsoft.Json;

namespace FirebaseAdmin.Messaging
{
    public sealed class WebpushFcmOptions
    {
        [JsonProperty("link")]
        public string Link { get; set; }

        internal WebpushFcmOptions CopyAndValidate()
        {
            var copy = new WebpushFcmOptions()
            {
                Link = this.Link,
            };

            if (copy.Link != null)
            {
	        // this https validation, that i want to remove
                if (!Uri.IsWellFormedUriString(copy.Link, UriKind.Absolute) || !copy.Link.StartsWith("https"))
                {
                    throw new ArgumentException("The link options should be a valid https url.");
                }
            }

            return copy;
        }
    }
}

Relevant Code:

using FirebaseAdmin;
using FirebaseAdmin.Messaging;
using Google.Apis.Auth.OAuth2;

var credential = GoogleCredential.FromFile("private-key.json");

FirebaseApp.Create(new AppOptions()
{
    Credential = credential
});

var registrationToken = "CLIENT_TOKEN_HERE";

var message = new Message()
{
    Token = registrationToken,
    Notification = new Notification()
    {
        Title = "Test title.",
        Body = "Test body.",
        
    },
    Webpush = new WebpushConfig()
    {
        FcmOptions = new WebpushFcmOptions()
        {
	    // http link that will be cheked
            Link = "http://127.0.0.1:5173"
        }
    },
    Android = new AndroidConfig()
    {
        Notification = new AndroidNotification()
        {
	    // this will not checked
            ClickAction = "http://127.0.0.1:5173"
        }
    }
};

var response = await FirebaseMessaging.DefaultInstance.SendAsync(message);

Console.WriteLine($"Successfully send message to {response}");
@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants