-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types doesnt match, no test to check #674
Comments
If only there was a technology that verified that types accurately describe your code ... |
Snarkiness aside - most of this file is just wrong anyways. |
I support that |
what was the motivation for that view to plugin attribute change? Do you expect every view type to have its own plugin? hmm... Would it be more prudent to keep the view attribute and just introduce plugin attribute for the plugin config options instead? I see them as two different entities. For example, a charts plugin might provide different chart type views, yet have one plugin config option. Also, I am sure this change breaks a lot of working examples online. |
I just love when @texodus closes random issues like this without any comments or intelligent followups. you do you! :) |
According to this file there is a
view
attribute, but it does not exist. It is now calledplugin
. There needs to be a test to check that the types file matches the real thing.The text was updated successfully, but these errors were encountered: