Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types doesnt match, no test to check #674

Closed
timkpaine opened this issue Jul 30, 2019 · 5 comments
Closed

Types doesnt match, no test to check #674

timkpaine opened this issue Jul 30, 2019 · 5 comments
Labels
bug Concrete, reproducible bugs JS

Comments

@timkpaine
Copy link
Member

timkpaine commented Jul 30, 2019

According to this file there is a view attribute, but it does not exist. It is now called plugin. There needs to be a test to check that the types file matches the real thing.

@timkpaine timkpaine added bug Concrete, reproducible bugs JS labels Jul 30, 2019
@texodus
Copy link
Member

texodus commented Aug 2, 2019

If only there was a technology that verified that types accurately describe your code ...

@texodus
Copy link
Member

texodus commented Aug 2, 2019

Snarkiness aside - most of this file is just wrong anyways. <perspective-viewer> is ultimately an HTML Element with some methods, and there's no native way to get an instance of a perspective-viewer in TypeScript, so my inclination is to remove this file and let TypeScript users write their own casts.

@timkpaine
Copy link
Member Author

I support that

@RandomFractals
Copy link

what was the motivation for that view to plugin attribute change?

Do you expect every view type to have its own plugin? hmm...

Would it be more prudent to keep the view attribute and just introduce plugin attribute for the plugin config options instead? I see them as two different entities. For example, a charts plugin might provide different chart type views, yet have one plugin config option.

Also, I am sure this change breaks a lot of working examples online.

@texodus texodus closed this as completed Aug 14, 2019
@RandomFractals
Copy link

I just love when @texodus closes random issues like this without any comments or intelligent followups. you do you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

No branches or pull requests

3 participants