Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when a view's size is likely to cause plugin rendering problems #226

Closed
texodus opened this issue Sep 2, 2018 · 1 comment
Assignees
Labels
enhancement Feature requests or improvements

Comments

@texodus
Copy link
Member

texodus commented Sep 2, 2018

For e.g. the Highcharts plugin, because the plugin renders the entire contents of the view, certain configurations can cause the browser to become unresponsive as the HTML/SVG/Canvas parts are rendered, even though Perspective itself may not similarly struggle. We should have a plugin-defined threshold that tells the viewer to display a user-overridable warning when the view is too large, rather than naively render.

@texodus texodus added the enhancement Feature requests or improvements label Oct 8, 2018
@sc1f sc1f self-assigned this Oct 15, 2018
@texodus
Copy link
Member Author

texodus commented Nov 8, 2018

This has been fixed in #290 and will be in the 0.2.4 release

@texodus texodus closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

No branches or pull requests

2 participants