Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid open/close row group indicator does not work on the TOTAL row when a split_by is present #1874

Closed
texodus opened this issue Jun 29, 2022 · 0 comments · Fixed by #1887
Labels
bug Concrete, reproducible bugs JS

Comments

@texodus
Copy link
Member

texodus commented Jun 29, 2022

Steps to Reproduce:

  1. Create a datagrid view with at least one group_by and split_by
  2. Click the open/close indicator next to the first row, TOTAL.

Expected Result:

The TOTAL row to close, leaving just this row present in the datagrid

Actual Result:

Nothing

Additional Context:

Shift+Click on a row group in the datagrid will expand/collapse all groups to that group's level. Collapsing, then expanding, a parent row in order to force all child groups to collapse seems to have evolved as a common usage pattern for Perspective, though this was never the intended workflow to accomplish this, and in fact it may make sense in the course of resolution of this issue to remove expand/collapse on a Datagrid's TOTAL row entirely.

In the video below, various row group levels are clicked with the Shift key held:

shift+click.mov
@texodus texodus added the bug Concrete, reproducible bugs label Jun 29, 2022
@timkpaine timkpaine added the JS label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs JS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants