-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perspective 1.0.2 and above does not work in Voila #1773
Comments
From the error screenshot, it looks like Voila is trying to load the plugin from CDN and using the wrong path ( |
i can probably update voila to check for the |
May be a bit more complex than that, as the general rules for module resolution are somewhat arbitrary (e.g. jsdelivr also respects a The error seems to indicate fetching from a CDN is an exception rather than the norm - would this be resolved by disting the plugin with |
If I just change the output location to |
original: #335 |
Not sure switching the output to a dist/index.js would solve the issue. We can configure require for voila to fetch the asset from the valid path : |
Same problem here, Perspective is working fine through JupyterLab, but inside Voila he is trying to get dist/index.js from CDN and it's no loger available since 1.0.2 . What I tried is to pass option enable_nbextensions=True to Voila, hoping that it could retrieve perspective-jupyterlab.js from local disk but it didn't work.. I can locate the file in /usr/local/share/jupyter/lab/staging/node_modules/@finos/perspective-jupyterlab/dist/umd/perspective-jupyterlab.js surely because I installed labextension (the npm part) and rebuilt jupyter, but voila doesn't seems to find it. Anyone did find a working solution? In meanwhile I'll be stick with the 1.0.1 ... |
There is no workaround, we can fix the cdn location but the best solution is for me to finish the prebuilt extension which will let it find perspective on disk. |
Has there been any progress on this ticket? |
@timkpaine Is resolution of this issue waiting on approval of your PR for voila issue 1154? |
Any updates here? |
should work after #2136 |
Bug Report
Steps to Reproduce:
Expected Result:
Working PerspectiveWidget instances.
Actual Result:
PerspectiveWidget can not be registered in Voila.
Environment:
Perspective > 1.0.1, Any OS, Voila 0.3.3 (same version for preview)
Additional Context:
Perspective Jupyterlab is now bundled as an ECMAScript module, and can not be loaded through requireJs into Voila.
This is related to #1611
The text was updated successfully, but these errors were encountered: