Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perspective Viewer does not work in Custom Element Examples remote_express and remote-express-typescript #1536

Closed
jconlon opened this issue Sep 10, 2021 · 2 comments

Comments

@jconlon
Copy link

jconlon commented Sep 10, 2021

Bug Report

Perspective Viewer does not work in Custom Element examples/remote_express and examples/remote-express-typescript

Steps to Reproduce:

  1. Clone, Install and Build project
  2. From the root of the project run: $ yarn start remote-express-typescript or $ yarn start remote-express
  3. Browsing to localhost:8080

Expected Result:

Expect to see the perspective viewer

Actual Result:

Blank Black screen, console exception:

perspective_viewer.js:1423 Uncaught (in promise) TypeError: _(...).then is not a function
    at n.wbg.__wbg_then_3d9a54b0affdf26d (perspective_viewer.js:1423)
    at perspective_viewer_bg.wasm:0x7541e
    at perspective_viewer_bg.wasm:0x5f589
    at perspective_viewer_bg.wasm:0x5bfe9
    at perspective_viewer_bg.wasm:0x82a72
    at perspective_viewer_bg.wasm:0x79b8d
    at perspective_viewer_bg.wasm:0xa9c49
    at perspective_viewer_bg.wasm:0xa20bf
    at perspective_viewer_bg.wasm:0x7d26d
    at perspective_viewer_bg.wasm:0x854ec

Environment:

latest version and build,
Ubuntu 20.04
Browsers:

  1. Chrome Version 93.0.4577.63 (Official Build) unknown (64-bit),
  2. Chromium Version 93.0.4577.63 (Official Build) snap (64-bit)
  3. Firefox 92.0

Additional Context:

  1. yarn test_js passes all tests.
  2. Have got the React example to work but not these two with the current version in the repo.
  3. Got these two examples to work by using the unpkg.com web libraries: in <script src="https://unpkg.com/@finos/perspective... but not the libraries in te current repo.
@texodus
Copy link
Member

texodus commented Oct 12, 2021

Thanks for the report! Please try this again on version 1.0.0 (which master was when you tried this, and is now released)

@texodus texodus closed this as completed Oct 12, 2021
@jconlon
Copy link
Author

jconlon commented Oct 12, 2021

Working fine now with 1.0.0. And my perspective tables are rendering much faster now and global menu in perspective-workspace now showing up in firefox! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants