Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define SDK #34

Closed
4 of 5 tasks
AttilaMihaly opened this issue Mar 25, 2020 · 1 comment
Closed
4 of 5 tasks

Define SDK #34

AttilaMihaly opened this issue Mar 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@AttilaMihaly
Copy link
Member

AttilaMihaly commented Mar 25, 2020

SDK Types should include:

  • Dict
  • List
  • LocalDate
  • Maybe
  • Result

For all of the above we need to add module mappings as seen here:
https://github.com/Morgan-Stanley/morphir-elm/blob/2dfd49aa61448374d4f9045e7aa54ffc660b88c9/src/Morphir/Elm/Frontend/Resolve.elm#L126-L130

Note: The SDK will always be included as a dependency to morphir packages. As seen here: https://github.com/Morgan-Stanley/morphir-elm/blob/2dfd49aa61448374d4f9045e7aa54ffc660b88c9/src/Morphir/Elm/Frontend.elm#L381-L384

@AttilaMihaly AttilaMihaly added the enhancement New feature or request label Mar 25, 2020
@AttilaMihaly AttilaMihaly changed the title Define SDK types Define SDK Mar 25, 2020
AttilaMihaly added a commit to AttilaMihaly/morphir-elm that referenced this issue Mar 25, 2020
AttilaMihaly added a commit that referenced this issue Mar 25, 2020
* Utilities to make the JSON mapping easier. #25

* Fix compile error. #25

* Fix `EncodersCLI`.

* Make source dir relative to project dir. #27

* Better error reporting in the frontend. #24

* Initial version of SDK. #34
@AttilaMihaly
Copy link
Member Author

This is generally to vague and most of what it referes have been completed. There is another issue for LocalDate specifically: #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant