Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow promises as updates return values #16

Closed
TiuSh opened this issue May 8, 2018 · 5 comments
Closed

Allow promises as updates return values #16

TiuSh opened this issue May 8, 2018 · 5 comments

Comments

@TiuSh
Copy link
Contributor

TiuSh commented May 8, 2018

feature request

What is the current behavior?

UpdatesByName and UpdatesForAll functions don't handle Promises as return values.

What is the expected behavior?

I'd love to be able to handle asynchronous updates using Promises inside updates functions.

Other information

I already experimented a little bit with the code, and I'm quite happy with the result. I'm ready to create a PR if you're willing to accept this feature !
@TiuSh TiuSh mentioned this issue May 8, 2018
Merged
@TiuSh
Copy link
Contributor Author

TiuSh commented Jun 1, 2018

Did anyone take a look on this issue & PR ?

@erikras
Copy link
Member

erikras commented Jun 1, 2018

Looks good. Will merge and publish on Monday. Please remind me if I don't.

@TiuSh
Copy link
Contributor Author

TiuSh commented Jun 1, 2018

Nice ! 👍

@peterpetre
Copy link

@erikras Reminder!

@erikras
Copy link
Member

erikras commented Jun 4, 2018

Published in v1.2.0.

@erikras erikras closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TiuSh @erikras @peterpetre