Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter's use of finagle-postgres #248

Open
willnorris opened this issue May 5, 2021 · 4 comments
Open

Twitter's use of finagle-postgres #248

willnorris opened this issue May 5, 2021 · 4 comments

Comments

@willnorris
Copy link

Twitter has relatively recently begun work on an internal project that will be using the PostgreSQL wire protocol, and are hoping to use finagle-postgres for that since it's a great project. Obviously, @vkostyukov (and more recently @steveniemitz and I suspect others) from Twitter have been contributing to the project, but we're interested in upping our involvement a bit.

The first question, mostly for @leonmaia but really any interested contributor or user of the project, is whether you're open to us stepping in to help with the maintenance of the project more. And then related to that, we wanted to propose the idea of promoting finagle-postgres to being a core part of the finagle project alongside finagle-mysql, finagle-redis, etc. That would allow the CSL team inside of Twitter to more easily maintain it with the rest of Finagle to keep it in sync with any changes, etc.

Anyway, we really like the project and are excited about using it, and would love to help however we can. 🎉

@vkostyukov
Copy link
Collaborator

@jeremyrsmith @leonmaia One extra thing we probably want to do before moving stuff around is to uncouple finagle-postgres-shapeless and move it under its own repo (within the Finagle Org as well). Since our goal is to move finagle-postgres under twitter/finagle, having a bonus shapeless dependency is probably something we'd like to avoid.

What are your thoughts on this?

@jeremyrsmith
Copy link
Collaborator

Hi @willnorris and @vkostyukov!

I can't speak for any other contributors, but in my current role I don't use either finagle nor postgres. And I've got my OSS-hands rather full (so to speak). But, I'm happy to answer any questions that I can (though it's been a while since I've done much of anything on this project).

@vkostyukov I don't see any problem with separating the repositories, assuming it wouldn't affect the artifact org/name.

@vkostyukov
Copy link
Collaborator

vkostyukov commented May 5, 2021

Thanks, @jeremyrsmith! Yea I think we should keep the artifacts publishing (and their location) unchanged. The finagle-postgres artifacts, however, would be published with the rest of Finagle projects so under com.twitter.finagle vs. io.twitter.finagle.

@vkostyukov
Copy link
Collaborator

Hey @leonmaia! We're going to start working on this pretty soon-ish. We'll start with splitting the shapeless bits out into their own repo.

Again, please let us know your thoughts and feelings on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants