Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle JSDoc visibility modifier #671

Closed
ajafff opened this issue Dec 26, 2019 · 0 comments
Closed

handle JSDoc visibility modifier #671

ajafff opened this issue Dec 26, 2019 · 0 comments
Assignees
@ajafff
Labels
upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler

Comments

@ajafff
Copy link
Member

ajafff commented Dec 26, 2019

Needs to support @protected and @private (microsoft/TypeScript#35731).

Also needs to support @readonly (microsoft/TypeScript#35790).

Probably just replace hasModifier with ts.getCombinedModifierFlags.
@ajafff ajafff added the API label Dec 26, 2019
@ajafff ajafff self-assigned this Dec 26, 2019
@ajafff ajafff added upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler and removed API labels Dec 26, 2019
@ajafff ajafff closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajafff ajafff

Labels
upstream compatibility Changes needed to support new/upcoming language features or API changes in the TypeScript compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajafff