Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of frames shown to prevent browser crashes #700

Closed
calvinalkan opened this issue Aug 4, 2021 · 3 comments
Closed

Limit the number of frames shown to prevent browser crashes #700

calvinalkan opened this issue Aug 4, 2021 · 3 comments

Comments

@calvinalkan
Copy link

Hello,

I have used whoops for some months in a project where I built a custom error handler that integrates nicely with whoops.

Recently I noticed that when an exception gets thrown after a relativly "large" stack trace (maybe 100 frames in whoops ) the error page initially rendors correctly bit as soon as I click one different frame in the side panel my entire browser freezes and then crashes. Tried in chrome and firefox on two pcs.

Is this to be expected? I could not find anything in the docs regarding setting a frame limit.

Thank you,

Calvin

@staabm
Copy link
Contributor

staabm commented Aug 5, 2021

Could you create a test case which reproduces the problem?

@denis-sokolov
Copy link
Collaborator

I suppose a setting to show only the top x frames could make sense to work around any limitations in the browser. A PR is welcome.

@denis-sokolov denis-sokolov changed the title [Question] Stack trace crashes chrome and firefox Limit the number of frames shown to prevent browser crashes Aug 6, 2021
@denis-sokolov
Copy link
Collaborator

I’ve added this to the list of possible features to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants