Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where the startup settings were ignored if a location is specified #12030

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Apr 9, 2023

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Startup settings are not followed when opened via explorer #11894

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Make Files the default file manager.
    2. Set the startup settings to other than "Open a new tab".
    3. Launch Files via "Open file location" in the Start menu.
    4. You see tabs are opened according to the startup settings in addition to the specified location.

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit 9f2c050 into files-community:main Apr 16, 2023
@@ -335,6 +335,30 @@ public async void OnNavigatedTo(NavigationEventArgs e)
}
else
{
try
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to add some comments for future reference

@hishitetsu hishitetsu deleted the FixOpenLocation branch April 16, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Startup settings are not followed when opened via explorer
2 participants