Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added media file resolution to the details pane #11402

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

puppetsw
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Partially closes #5075. There is a request to allow users to customise the information in the details pane which hasn't been implemented here.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
image

yaira2
yaira2 previously approved these changes Feb 21, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We still need to work on a UI for editing data in the preview pane, let me know if you're interested.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 21, 2023
@yaira2 yaira2 changed the title Feature: Show additional resolution info on media files in details pane Feature: Added media file resolution to the details pane Feb 21, 2023
@puppetsw
Copy link
Contributor Author

LGTM

We still need to work on a UI for editing data in the preview pane, let me know if you're interested.

@yaira2 I'm interested in working on this. Do you have any thoughts/concepts for how it will look?

@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2 yaira2 merged commit 9e39f24 into files-community:main Feb 22, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 22, 2023

@puppetsw I think that if a user makes any changes, a save and cancel button should appear the bottom of the details pane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Added resolution info to details pane
2 participants