Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to sort pinned files (items) #2011

Closed
whdmike opened this issue Oct 1, 2020 · 11 comments · Fixed by #2116
Closed

Option to sort pinned files (items) #2011

whdmike opened this issue Oct 1, 2020 · 11 comments · Fixed by #2116
Assignees

Comments

@whdmike
Copy link

whdmike commented Oct 1, 2020

Is your feature request related to a problem? Please describe.
I would like to be able to sort pinned items (on a left). Now I can pin them, but if I want to change the order of importance for me, I can't.

Describe the solution you'd like
be able to sort pinned files (items)

Describe alternatives you've considered
just that, option to sort pinned files. Windows file explorer can do, you can do also

Additional context

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.80. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@DanielSlincak
Copy link
Contributor

Hi, could I work on this issue? @yaichenbaum

@yaira2
Copy link
Member

yaira2 commented Oct 6, 2020

@DanielSlincak Sure!

@DanielSlincak
Copy link
Contributor

I'll make a pull request by the end of the week. I'm working on two ways on how to sort the pinned items. The first is by dragging and dropping them - the implementation for this is finished. The second one is by right-clicking and selecting from pre-determined sort options - name, date added, ascending and descending. I'm still working on a few details with this implementation.

@yaira2
Copy link
Member

yaira2 commented Oct 20, 2020

@DanielSlincak Sort by date is not necessary, we only plan to implement the option to reorder the pinned items manually.

@DanielSlincak
Copy link
Contributor

@yaichenbaum Okay, should I disable it, or remove all the code for the implementation as well? You can check it in the pull request.

@yaira2
Copy link
Member

yaira2 commented Oct 20, 2020

@DanielSlincak You should probably remove the code for the sorting option.

@whdmike
Copy link
Author

whdmike commented Nov 27, 2020

I see that this feature is already "implemented", but still in the last 0.21 version I am not able to sort pinned folders. Am I missing something? Thanks

@yaira2
Copy link
Member

yaira2 commented Nov 27, 2020

@whdmike The code is already there and implemented, however we are waiting on a fix in the WinUI library for an issue that breaks this functionality before we enable it.

@whdmike
Copy link
Author

whdmike commented Dec 12, 2020

@whdmike The code is already there and implemented, however we are waiting on a fix in the WinUI library for an issue that breaks this functionality before we enable it.

I think there are few options how sorting can be done - in a case you have problems with code and you are not able to implement it - one option is drag and drop like windows file explorer and another option is like most of other file explorers have, separate option to sort/manage pinned/favorite folders (xyplorer, zabkat,Freecommander, ,..). Just an idea if might help.

@yaira2
Copy link
Member

yaira2 commented Dec 13, 2020

@whdmike The feature was implemented using the drag and drop option, however there is currently an issue where drag and drop isn't working microsoft/microsoft-ui-xaml#3290.

@gave92 gave92 mentioned this issue Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants