Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to create tags from the Tags section and from the context menu #12146

Open
Marin-Kitagawa opened this issue Apr 21, 2023 · 14 comments · May be fixed by #16475
Open

Feature: Ability to create tags from the Tags section and from the context menu #12146

Marin-Kitagawa opened this issue Apr 21, 2023 · 14 comments · May be fixed by #16475
Labels
area - tags Features or bug reports for Tags

Comments

@Marin-Kitagawa
Copy link

Marin-Kitagawa commented Apr 21, 2023

What feature or improvement do you think would benefit Files?

I want to have an option to create Tags from the Tags section (image below) and from the content menu. The context menu just provides the ability to assign tags. To create a tag, I have to go to settings, go to Tabs menu and then create a new tag. Why? Please make it simpler

image

Requirements

  • Add option to tags context menu to "Edit tags"
  • Clicking this option should open the tags page in settings

Files Version

2.4.66.0

Windows Version

Windows 11 Pro 10.0.22621.1555

Comments

No response

@yaira2
Copy link
Member

yaira2 commented Apr 21, 2023

Thank you for your feedback

@yaira2 yaira2 changed the title Ability to create tags from the Tags section and from the context menu Feature: Ability to create tags from the Tags section and from the context menu Apr 21, 2023
@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Apr 21, 2023
@Marin-Kitagawa
Copy link
Author

Wow. That was really fast

@yaira2
Copy link
Member

yaira2 commented Apr 21, 2023

@Marin-Kitagawa we still have to finalize the requirements on how this will be implemented but it's definitely on our radar.

@Marin-Kitagawa
Copy link
Author

@yaira2 Sure. Looking forward to it ☺️

@hecksmosis
Copy link
Contributor

We should probably add this to the context menu in the sidebar

@Marin-Kitagawa
Copy link
Author

@hecksmosis Adding it in context menu and in the Tags section (above image) would be great instead of just in the context menu

@hecksmosis
Copy link
Contributor

@hecksmosis Adding it in context menu and in the Tags section (above image) would be great instead of just in the context menu

Yes, I think doing both is a good idea, I was just saying that for the sidebar one we should add it in the context menu for the sidebar items. We could do a popup and reuse it in both cases, couldn't we @yaira2 ?

@yaira2
Copy link
Member

yaira2 commented Apr 23, 2023

@hecksmosis I was hoping that we could open directly to the settings page to reduce duplicating the UI but we'll have to rework settings dialog before this is possible.

@yaira2 yaira2 added the area - tags Features or bug reports for Tags label Oct 27, 2023
@yaira2 yaira2 assigned yaira2 and unassigned yaira2 Nov 26, 2023
@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Nov 26, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 18, 2024

The direction we're probably going to take is to

  1. Add an option to "Create tag", this will open a popup modal and allow the user to create a new tag.
  2. Add an option to delete tags when right clicking them in the sidebar.
  3. Add option when right clicking the tag section in the sidebar to "Manage tags", this should open the tags page in settings.

@0x5bfa
Copy link
Member

0x5bfa commented May 15, 2024

I guess we can add a context menu to the section header item as we also have an option to open a dialog to map a network location in widget drive section(meaning we can do this for this option as well). Currently we, however, don't have a way to know the section item is the section because it is LocationItem which is the same as we use for folders in Pinned section. If we create a class named SidebarSectionItem or SidebarSpecialItem, we can achieve.

FYI, FileExplorer already supports this.

@ferrariofilippo
Copy link
Contributor

Hi, I started working on this. Is this concept what you were thinking about:
Image
Image
Image
Image

Having been away for a long time, I am not up to date with the project - is there any “deep-link” to access the settings yet?

@yaira2
Copy link
Member

yaira2 commented Nov 15, 2024

The plan is to add an 'Edit tags' menu option which will deep link into settings.

Having been away for a long time, I am not up to date with the project - is there any “deep-link” to access the settings yet?

Not yet, but I think this will need to be added before this feature can be implemented.

@ferrariofilippo
Copy link
Contributor

Something like this?

Registrazione.dello.schermo.2024-11-15.162727.mp4

Anyway, what are deep-links needed for? If they are used only to access the Settings Dialog I think we can simply use a parameter for OpenSettingsCommand

@yaira2
Copy link
Member

yaira2 commented Nov 15, 2024

Something like this?

Yes!

Anyway, what are deep-links needed for? If they are used only to access the Settings Dialog I think we can simply use a parameter for OpenSettingsCommand

That's what I had in mind 👍

@yaira2 yaira2 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - tags Features or bug reports for Tags
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

5 participants