Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue where 'Run with PowerShell' action didn't include quotes with launch arguments #16455

Closed
wants to merge 3 commits into from

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

@0x5bfa
Copy link
Member

0x5bfa commented Nov 10, 2024

Please provide steps you validated this change.

@Lamparter
Copy link
Contributor Author

Hang on

@yaira2 yaira2 changed the title Fix: Added quotes to PowerShell location launch arguments Fix: Fixed an issue where 'Run with PowerShell' action didn't include quotes with launch arguments Nov 10, 2024
@yaira2
Copy link
Member

yaira2 commented Nov 10, 2024

It looks like the issue is still present

@Lamparter
Copy link
Contributor Author

Yeah I know I'm working on it

@yaira2
Copy link
Member

yaira2 commented Nov 11, 2024

It's still an issue with the latest commit

@Lamparter
Copy link
Contributor Author

Yes I'm aware, I'll try again with it a bit later

@Lamparter
Copy link
Contributor Author

Sorry for opening the pr early before finding out whether the issue is fixed it's just the only way I can get the package is from the ci run.

@yaira2
Copy link
Member

yaira2 commented Nov 11, 2024

That's fine, I'll wait until it's ready.

@yaira2 yaira2 marked this pull request as draft November 11, 2024 16:02
@Lamparter Lamparter closed this Nov 15, 2024
@Lamparter
Copy link
Contributor Author

There's still something else I haven't tried but it's unlikely to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Run with PowerShell toolbar button doesn't quote path
3 participants