Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: The new item dialog cannot be canceled #13787

Closed
hishitetsu opened this issue Nov 10, 2023 · 4 comments · Fixed by #13846
Closed

Bug: The new item dialog cannot be canceled #13787

hishitetsu opened this issue Nov 10, 2023 · 4 comments · Fixed by #13846
Assignees
@MrFrawsty
Labels
good first issue Good issue for new contributors to get started with

Comments

@hishitetsu
Copy link
Member

hishitetsu commented Nov 10, 2023 •
edited
Loading

Description

When I press Ctrl+Shift+I, the new item dialog appears. But once creating a new item, this dialog cannot be canceled even if I press the Cancel button and a dialog to enter a new name will appear.

Steps To Reproduce

  1. Press Ctrl+Shift+I and create a new item.
  2. Press Ctrl+Shift+I again.
  3. Press Cancel on the dialog.
  4. The operation is not canceled and a dialog to enter a new name appears.

Requirements

The operation should be canceled when Cancel is pressed.

Files Version

3.0.3.0

Windows Version

10.0.22631.2506

Log File

n/a
@hishitetsu hishitetsu added the bug label Nov 10, 2023
@hishitetsu hishitetsu changed the title Bug: The new item dialog cannot canceled Bug: The new item dialog cannot be canceled Nov 10, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 10, 2023

Thanks for the report.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Nov 10, 2023
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Nov 10, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 10, 2023

I can't repro this issue

@hishitetsu
Copy link
Member Author

I can't repro this issue

I've updated the Steps To Reproduce because I've found that there are conditions under which the problem can occur.

@MrFrawsty
Copy link
Contributor

I found the problem if I could be assigned to this issue so nobody else starts looking into it please :)

@MrFrawsty MrFrawsty mentioned this issue Nov 13, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrFrawsty MrFrawsty

Labels
good first issue Good issue for new contributors to get started with
Projects
Files task board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed: Fixed issue where the new item dialog cannot be canceled
3 participants
@MrFrawsty @yaira2 @hishitetsu