Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Create alike RichCommands inheritance #13132

Closed
5 tasks
QuaintMako opened this issue Aug 5, 2023 · 1 comment · Fixed by #13155
Closed
5 tasks

Code Quality: Create alike RichCommands inheritance #13132

QuaintMako opened this issue Aug 5, 2023 · 1 comment · Fixed by #13155

Comments

@QuaintMako
Copy link
Contributor

Description

Some of the existing Rich Commands have an implementation similar enough they could be deriving from a common base class. Such work as already be done for the Rotation or commands

Concerned code

The following Rich commands should be fused:

  • Run as commands
  • Compress into archive commands
  • Decompress archive commands
  • Restore recycle bin commands
  • Tab closing commands

Gains

  • Reduced duplication
  • Centralized logic

Requirements

  • Akin rich commands are inheriting from the same base class

Comments

No response

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Aug 6, 2023
@yaira2
Copy link
Member

yaira2 commented Aug 6, 2023

Thank you for the feedback

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Aug 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants