Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Backplates will be displayed when hovering in High Contrast #13078

Closed
0x5bfa opened this issue Jul 26, 2023 · 13 comments
Closed

Bug: Backplates will be displayed when hovering in High Contrast #13078

0x5bfa opened this issue Jul 26, 2023 · 13 comments
Assignees

Comments

@0x5bfa
Copy link
Member

0x5bfa commented Jul 26, 2023

Description

As the title

image

Steps To Reproduce

  1. Make Windows HC
  2. Open Files
  3. Hover something that have TextBlock.

Requirements

  • Remove backplates

Files Version

2.5.20

Windows Version

10.0.22000

Log File

None

@0x5bfa 0x5bfa added the bug label Jul 26, 2023
@0x5bfa 0x5bfa self-assigned this Jul 26, 2023
@yaira2 yaira2 moved this to 🔖 Ready to build in Files task board Jul 26, 2023
@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Jul 28, 2023
@yaira2
Copy link
Member

yaira2 commented Aug 20, 2023

Is this only on the sidebar and details layout?

@yaira2 yaira2 moved this from 🏗 In progress to 📋 Planning stage in Files task board Aug 20, 2023
@mdtauk
Copy link
Contributor

mdtauk commented Aug 22, 2023

Is this only on the sidebar and details layout?

This is what UIElement.HighContrastAdjustment will handle

https://learn.microsoft.com/en-us/uwp/api/windows.ui.xaml.uielement.highcontrastadjustment?view=winrt-22621

@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 22, 2023

So all controls using UIElement have this issue.

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Aug 27, 2023
@mdtauk
Copy link
Contributor

mdtauk commented Sep 12, 2023

@0x5bfa

@yaira2 By default they want to prioritise the readability of text. But because it is not visually appealing, they allow you to set the High Contrast Adjustment - to remove this behaviour | as long as the app developer has ensured the text contrast is readable.

If you want to remove the backplate, check every element to ensure text is always readable

@mdtauk
Copy link
Contributor

mdtauk commented Sep 12, 2023

[image

This is the Tab control as an example, from when they fixed the issue in the controls

@yaira2
Copy link
Member

yaira2 commented Sep 12, 2023

So is the expected design to have black text without a backplate?

@mdtauk
Copy link
Contributor

mdtauk commented Sep 12, 2023

So is the expected design to have black text without a backplate?

Anything highlighted, needs the correct text colour.

@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Nov 9, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 9, 2023

There appears to be an issue where setting the property in app.xaml doesn't work. We can work around by setting it on the individual page, but we'd prefer to avoid doing this.

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Nov 9, 2023
@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Nov 9, 2023
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Nov 9, 2023
@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 9, 2023

There appears to be an issue where setting the property in app.xaml doesn't work. We can work around by setting it on the individual page, but we'd prefer to avoid doing this.

I should work though, when I tried last time I worked well. But Dialog class and MenuFlyout class doesn't respect this setting in App.xaml so need to set indivisually or we can find another way if any.

@yaira2
Copy link
Member

yaira2 commented Nov 9, 2023

@0x5bfa it's not too bad if it's just dialogs and menu flyouts. Let's do this 👍

@0x5bfa
Copy link
Member Author

0x5bfa commented Nov 10, 2023

Alright!

@yaira2
Copy link
Member

yaira2 commented Feb 5, 2024

This should be resolved in main.

@yaira2 yaira2 closed this as completed Feb 5, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Feb 5, 2024
@0x5bfa 0x5bfa reopened this Feb 7, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in Files task board Feb 7, 2024
@0x5bfa
Copy link
Member Author

0x5bfa commented Feb 7, 2024

image

@yaira2 yaira2 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants