Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Files is unable to load more then 3 drives on homepage and sidebar #12981

Closed
Josh65-2201 opened this issue Jul 19, 2023 · 7 comments · Fixed by #12986
Closed

Bug: Files is unable to load more then 3 drives on homepage and sidebar #12981

Josh65-2201 opened this issue Jul 19, 2023 · 7 comments · Fixed by #12986

Comments

@Josh65-2201
Copy link
Member

Description

2.3.14 showed all the drives. Now 2.3.16 only show B, C and D

Steps To Reproduce

  1. Have more then 3 drives
  2. Open Files
  3. See others missing

Requirements

  • Show all drives

Files Version

2.4.16.0

Windows Version

10.0.22621.1928

Log File

debug.log
@Josh65-2201
Copy link
Member Author

I have found it only happens when I safely eject a drive but don't actually remove it from the system. Any drive letter beyond the ejected one wont load.

@yaira2
Copy link
Member

yaira2 commented Jul 19, 2023

Is this fixed in v2.5.17?

@0x5bfa
Copy link
Member

0x5bfa commented Jul 19, 2023

@0x5bfa it seems like this is from the splash screen work.

What do you mean? Splash screen work isn't even merged.

@yaira2
Copy link
Member

yaira2 commented Jul 19, 2023

v2.5.16 included the splash screen for testing purposes.

@hishitetsu
Copy link
Member

It seems a regression caused by #12931. The following code seems to fail to get the volume label.
https://github.com/gave92/files-uwp/blob/0ca7278581bb3a6b7fbb91cc9b06be12bd6b91d6/src/Files.App/Helpers/Storage/DriveHelpers.cs#L140-L153

@yaira2
Copy link
Member

yaira2 commented Jul 20, 2023 •
edited
Loading

@0x5bfa I apologize, this isn't from the splash screen. Sorry for the confusion.

@hishitetsu
Copy link
Member

I will prepare a quick fix.

@hishitetsu hishitetsu mentioned this issue Jul 20, 2023
Merged
8 tasks
@Josh65-2201 Josh65-2201 moved this from 🆕 New to 🏗 In progress in Files task board Jul 20, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Files task board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Fixed issue that sometimes prevented drives from being displayed hishitetsu/Files
4 participants
@Josh65-2201 @yaira2 @0x5bfa @hishitetsu