Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Save tabs on Windows shutdown or app crash #12624

Closed
HobbesKo opened this issue Jun 15, 2023 · 6 comments · Fixed by #14795
Closed

Feature: Save tabs on Windows shutdown or app crash #12624

HobbesKo opened this issue Jun 15, 2023 · 6 comments · Fixed by #14795
Labels
help wanted Extra attention is needed

Comments

@HobbesKo
Copy link

HobbesKo commented Jun 15, 2023

What feature or improvement do you think would benefit Files?

See #12619 - Startup Setting Ignored if Files Not Closed Before PC Shutdown.

Requirements

  • Honour the startup state if Files is open when the PC is shutdown.

Files Version

2.5.1.0

Windows Version

Windows 11 (22H2): 22621

@yaira2 yaira2 changed the title Detect PC Shutdown Feature: Save tabs on Windows shutdown Jun 15, 2023
@yaira2
Copy link
Member

yaira2 commented Jun 15, 2023

Thank you for the feedback

@clackwell
Copy link

Just a note on implementation: One must always assume that the computer can be turned off "hard", that the application crashes or that the whole computer crashes - at any point in time. This means that one must save (relevant and modified) state ASAP, immediately.

Also, the saving process may equally be interrupted by power outage, etc. So the writing should be done in a way that no data corruption can occur, for example into a "temporary" settings file, and then replace the current file with this new file in an atomic step, or in well known steps that can be recovered. (When interrupted in between individual file renames, one must be able to detect this and take the right measure to roll back or roll forward, pushing through with the update of the stored state.)

@yaira2 yaira2 changed the title Feature: Save tabs on Windows shutdown Feature: Save tabs on Windows shutdown or app crash Jan 31, 2024
@MarathonMax
Copy link

I see a lot of mention of opened tabs. Can opened windows (i.e.: multiple instances of app) be saved as well?

@Dennis-AS
Copy link

Dennis-AS commented Feb 20, 2024

I just lost my tabs again and this time I am not sure why. I had Files open with multiple tabs when I left my computer. When I returned it had closed and when I reopened it my tabs were gone.
Maybe it closed because the Microsoft Store automatically installed the latest update.

Files needs to somehow always remember tabs (and possibly windows as well) no matter how it gets closed. Currently it only seems to remember tabs if it is closed normally. If it is closed in any other way (app crash, Windows crash, automatic update, anything else, etc.) it does not remember them.

I also submitted Feature Request # 14545 which is related and would at least make it not as bad if Files doesn't remember the tabs when started.

I have attached my current debug.log file in case it is helpful.
Like I stated earlier, I am not sure why Files was closed when I came back to my computer.

debug.log

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Feb 21, 2024
@yaira2
Copy link
Member

yaira2 commented Feb 21, 2024

This issue will be resolved in the next release.

@yaira2
Copy link
Member

yaira2 commented Feb 21, 2024

I see a lot of mention of opened tabs. Can opened windows (i.e.: multiple instances of app) be saved as well?

This isn't supported yet, can you open a feature request to track this feedback?

@yaira2 yaira2 reopened this Mar 1, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in Files task board Mar 1, 2024
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Mar 1, 2024
@yaira2 yaira2 added the help wanted Extra attention is needed label Mar 1, 2024
@yaira2 yaira2 closed this as completed Mar 1, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Archived in project
5 participants