Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: When closing the secondary pane with a shortcut, the primary pane stops working as expected. #12202

Closed
rafaskb opened this issue Apr 25, 2023 · 4 comments · Fixed by #12213

Comments

@rafaskb
Copy link

rafaskb commented Apr 25, 2023

Description

When we have two panes open in Files and we close the secondary one with the keyboard shortcut Ctrl + Shift + W, the primary pane doesn't regain focus automatically, so opening a folder from the favorites menu no longer works.
A workaround is to click the primary pane again, so it becomes active and focused, and then opening something from the favorites sidebar.

Files.-.Pane.doesn.t.have.focus.2.mp4

Steps To Reproduce

  1. Open Files with both panes active.
  2. Click on the second pane, so it's active and has focus.
  3. Press the keyboard shortcut Ctrl + Shift + W to close the secondary pane.
  4. Try to open a folder from the favorites menu.
  5. That won't work because the primary pane is not focused, therefore nothing happens.

Requirements

  • Fix bug described above

Files Version

2.4.68.0

Windows Version

10.0.19044.2846

Log file


@rafaskb rafaskb added the bug label Apr 25, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 25, 2023

@rafaskb this time we don't actually need the log file but in the future, can you upload the actual file instead of copying the text?

@rafaskb
Copy link
Author

rafaskb commented Apr 25, 2023

@rafaskb this time we don't actually need the log file but in the future, can you upload the actual file instead of copying the text?

I did include the whole content of the debug log in the original issue, seems like it's no longer there though. Is there any difference between including the content of the file and the file itself?

@Josh65-2201
Copy link
Member

We ask users to upload the file and not copy and paste the contents into the box so it doesn't make a long wall of text on GitHub and allows for searching/reading the contents of the log easier.

@yaira2
Copy link
Member

yaira2 commented Apr 26, 2023

@rafaskb a fix has been implemented and will be part of the next feature release (v2.5).

@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants