Bug: Creating, renaming, or deleting an item causes Files to select additional items

[ggtylerr]

Description

When creating a new folder and giving it a name (and using the preview version of Files), it instead makes a folder called "New Folder", and then selects other items.

Desktop.-.Files.2023-01-26.13-57-41.mp4

This issue is more apparent in bigger directories, as there's more files and folders to select.

Steps To Reproduce

1. Use the preview version
2. Make a new folder
3. Try to name it
4. Confirm

Steps to fix

• Actually name the folder
• Don't select other folders / items after confirmation (maybe it's tied to the feature where you press A and you select the first file / folder that starts with A)

Files Version

2.4.24.0

Windows Version

Windows 11 22H2 22621.1105

Log file

debug.log

[Josh65-2201]

The naming issue has been fixed and will be included in the next update

[yaira2]

@Josh-65 does it fix the selection issue too?

[Josh65-2201]

No. Not that ive seen anyway

[yaira2]

@Josh-65 I can't reproduce this anymore, can you check if it's still an issue?

[ggtylerr]

I'm still able to on v2.4.31.0. Not sure when building from source (kinda don't want to reinstall visual studio rn.)
It's most noticeable on directories with lots of files.

[yaira2]

That might be why, I was testing in a folder with three items.

[QuaintMako]

It seems to be linked to a timing issue. When using breakpoints to debug, the issue seems to not reproductible. The selected additional items be are also consistent regarding to the renamed item. (I'm yet to find the logic behind)

Might be linked to a fire and forget call, or an await that does not work properly.

[hishitetsu]

I managed to find suspicious behavior.
When I created a folder named ggg, multiple ContainerContentChanging events occurred. I found one of these events has different properties than expected.

Item and ItemContainer.Content refer to different items. Because of this, it appears to check the Visual Studio 2022 checkbox with the intention of checking the ggg checkbox.
I have no idea why this would happen.

[yaira2]

@chingucoding

[ggtylerr]

After a bit of testing, I've noticed this also happens with files, meaning it's most likely tied to general item events. Updated the title to reflect this.

[hishitetsu]

I managed to find a way to fix it! I will submit a PR later.

[hecksmosis]

@yaira2 You should probably unpin this

[yaira2]

Will do, thank you.