Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 把messager状态改成更容易理解 / clarify message state (unfill/filled) #5903

Open
1 of 11 tasks
hunjixin opened this issue Apr 13, 2023 · 1 comment
Open
1 of 11 tasks

feat: 把messager状态改成更容易理解 / clarify message state (unfill/filled) #5903

hunjixin opened this issue Apr 13, 2023 · 1 comment
Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon V-venus-messager venus-messager component

Comments

@hunjixin
Copy link
Contributor

hunjixin commented Apr 13, 2023 •
edited
Loading

链服务模块 / Chain Service Components

  • venus
  • venus-auth
  • venus-gateway
  • venus-messager
  • venus-miner
  • 文档 / docs

订单服务模块 / Deal Service Components

  • venus-market
  • 文档 / docs

算力服务模块 / Storage Power Service Components

  • venus-sector-manager
  • venus-worker
  • 文档 / docs

描述 / Description

现在的unfill/filled状态分表表示messager接收到消息但是还没有预估签名/ messager已经预估并把消息发送到网络当中。
当时起这个名字更多的是从代码流程中来看，但是不符合区块链里面常用的概念。 因此这里需要换一个更容易被用户理解的名称

目前考虑改成 Unsigned/Pending
@hunjixin hunjixin added C-enhancement Category: feature enhancement P2 Medium - we should get to this soon V-venus-messager venus-messager component labels Apr 13, 2023
@elvin-du
Copy link
Collaborator

赞同，昨天我看到fill消息状态这个概念就蒙了。Google了一遍也没有没有找到解释，看了代码才知道啥意思

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: feature enhancement P2 Medium - we should get to this soon V-venus-messager venus-messager component
Projects
Venus Project
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elvin-du @hunjixin