Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packing deals improvements #2692

Closed
arajasek opened this issue Jun 25, 2020 · 2 comments
Closed

Packing deals improvements #2692

arajasek opened this issue Jun 25, 2020 · 2 comments

Comments

@arajasek
Copy link
Contributor

  • We should add a timer / some other way to start sealing (currently needs a manual instruction)
  • Do something smarter than needing deals in the same sector to be of the same size. We can pad as needed to allow any incoming deal to align with the tree boundary, or "remember" holes (and try to get deals for those holes, and only pad at the latest possible time)
  • Replace the "previous pieces" array in AddPiece with an offset (the pieces themselves aren't used for anything except deciding where the new stuff needs to go).
  • See @magik6k's review comments in Pack multiple deals into a sector storage-fsm#38 for more necessary improvements
@arajasek
Copy link
Contributor Author

Also, auto-start sealing filled sectors.

@daviddias daviddias transferred this issue from filecoin-project/storage-fsm Jul 30, 2020
@arajasek
Copy link
Contributor Author

Being tracked in #2363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviddias @arajasek