Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubmitPoSt psuedocode represents "recovered" and "done" as "BitField", but docs use "SectorSet" type #276

Closed
laser opened this issue May 14, 2019 · 3 comments
Assignees

Comments

@laser
Copy link
Contributor

laser commented May 14, 2019

The SubmitPoSt portion of the specs lists the method's parameter names and types:

Parameters:
    proofs []PoStProof
    faults []FailureSet
    recovered SectorSet
    done SectorSet

However, the pseudocode uses different types:

func SubmitPost(proofs []PoStProof, faults []FaultSet, recovered BitField, done BitField) {

Both BitField and SectorSet exist in our Data Structures spec - so it's not clear to me which of the two types we should use.

Should the SubmitPoSt method accept BitField or SectorSet for recovered and done?

@laser laser changed the title SubmitPoSt psuedocode represent "recovered" and "done" as BitField, but docs use "SectorSet" type SubmitPoSt psuedocode represent "recovered" and "done" as "BitField", but docs use "SectorSet" type May 14, 2019
@laser laser changed the title SubmitPoSt psuedocode represent "recovered" and "done" as "BitField", but docs use "SectorSet" type SubmitPoSt psuedocode represents "recovered" and "done" as "BitField", but docs use "SectorSet" type May 14, 2019
@ZenGround0
Copy link
Contributor

Looking over related issues it is becoming increasingly clear that these params should be bitfields. I'm going to speculatively submit a patch.

@pooja
Copy link
Contributor

pooja commented May 28, 2019

cc @dignifiedquire (for its relevance to PR #251 )

Need to clarify that FailureSet is an array of Bitfields, faults recovered and done use RLE bitfields

@dignifiedquire
Copy link
Contributor

they are bitfields in master now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants