This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
suggested changes
Sep 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, there is one paranoid change I want to see happen before merging
Codecov Report
@@ Coverage Diff @@
## master #1489 +/- ##
======================================
Coverage 71.5% 71.5%
======================================
Files 72 72
Lines 8611 8612 +1
======================================
+ Hits 6158 6159 +1
Misses 1563 1563
Partials 890 890 |
ZenGround0
approved these changes
Sep 26, 2021
ZenGround0
pushed a commit
that referenced
this pull request
Oct 13, 2021
* two more failing tests but otherwise working * code review? code reviewed. * tests passin\' * https://www.youtube.com/watch?v=W1i4mTyidOc check pass * found the source of the cbor errors.... forgot about gen.go. * fixes for code review * bump determinism hash Co-authored-by: ZenGround0 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing repeated calls to reward and power actors from OnDeferredCronEvent method... branched off some other PRs that hopefully will land on master before this one!