Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Fix #1486 #1489

Merged
merged 7 commits into from
Oct 1, 2021
Merged

Fix #1486 #1489

merged 7 commits into from
Oct 1, 2021

Conversation

laudiacay
Copy link
Contributor

Removing repeated calls to reward and power actors from OnDeferredCronEvent method... branched off some other PRs that hopefully will land on master before this one!

@laudiacay laudiacay requested a review from a team as a code owner September 22, 2021 21:36
@laudiacay laudiacay changed the base branch from master to fix-799 September 22, 2021 21:36
Copy link
Contributor

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, there is one paranoid change I want to see happen before merging

actors/builtin/miner/miner_test.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/power/power_actor.go Outdated Show resolved Hide resolved
actors/test/commit_post_test.go Show resolved Hide resolved
actors/builtin/shared.go Outdated Show resolved Hide resolved
actors/builtin/shared.go Outdated Show resolved Hide resolved
actors/builtin/shared.go Outdated Show resolved Hide resolved
Base automatically changed from fix-799 to master September 23, 2021 16:29
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021

Codecov Report

Merging #1489 (ec31e9f) into master (12dfdc3) will increase coverage by 0.0%.
The diff coverage is 91.6%.

@@          Coverage Diff           @@
##           master   #1489   +/-   ##
======================================
  Coverage    71.5%   71.5%           
======================================
  Files          72      72           
  Lines        8611    8612    +1     
======================================
+ Hits         6158    6159    +1     
  Misses       1563    1563           
  Partials      890     890           

actors/builtin/miner/miner_actor.go Outdated Show resolved Hide resolved
actors/builtin/power/power_actor.go Outdated Show resolved Hide resolved
actors/builtin/power/power_test.go Outdated Show resolved Hide resolved
@ZenGround0 ZenGround0 merged commit ea6fa6b into master Oct 1, 2021
@ZenGround0 ZenGround0 added this to the Network v14 milestone Oct 12, 2021
ZenGround0 pushed a commit that referenced this pull request Oct 13, 2021
* two more failing tests but otherwise working
* code review? code reviewed.
* tests passin\'
* https://www.youtube.com/watch?v=W1i4mTyidOc check pass
* found the source of the cbor errors.... forgot about gen.go.
* fixes for code review
* bump determinism hash
Co-authored-by: ZenGround0 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants